Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add IsAlphanumericExpectUnderscore to k8s modules and caprover, #3552

Merged
merged 1 commit into from
Oct 28, 2024
Merged

add IsAlphanumericExpectUnderscore to k8s modules and caprover, #3552

merged 1 commit into from
Oct 28, 2024

Conversation

0oM4R
Copy link
Contributor

@0oM4R 0oM4R commented Oct 24, 2024

Description

allow underscore in dashboard k8s validations

Changes

add IsAlphanumericExpectUnderscore to all k8s models and addMachineModel

Related Issues

Tested Scenarios

with underscore in the name

  • attache caprover worker, delete it
  • create k8s cluster, add worker, delete worker, delete cluster
    Screenshot from 2024-10-24 15-32-37
    Screenshot from 2024-10-24 15-11-46
    Screenshot from 2024-10-24 15-03-41

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

@0oM4R
chore: add IsAlphanumericExpectUnderscore to k8s modules and caprover,
5370c2c 
allow undersocre in dashboard k8s validations
@0oM4R 0oM4R added this to the 2.6.0 milestone Oct 24, 2024
@0oM4R 0oM4R merged commit a78daae into development Oct 28, 2024
10 checks passed
@0oM4R 0oM4R deleted the development_orchestrators_name branch October 28, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samaradel samaradel samaradel approved these changes

@amiraabouhadid amiraabouhadid amiraabouhadid approved these changes

@AhmedHanafy725 AhmedHanafy725 Awaiting requested review from AhmedHanafy725 AhmedHanafy725 is a code owner

@zaelgohary zaelgohary Awaiting requested review from zaelgohary zaelgohary is a code owner

@maayarosama maayarosama Awaiting requested review from maayarosama maayarosama is a code owner

@MohamedElmdary MohamedElmdary Awaiting requested review from MohamedElmdary MohamedElmdary is a code owner

@Mahmoud-Emad Mahmoud-Emad Awaiting requested review from Mahmoud-Emad Mahmoud-Emad is a code owner

@AlaaElattar AlaaElattar Awaiting requested review from AlaaElattar AlaaElattar is a code owner

Assignees
No one assigned
Labels
dashboard grid_client
Projects
None yet
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@0oM4R @samaradel @amiraabouhadid