Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add IsAlphanumericExpectUnderscore to k8s modules and caprover, #3552

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

0oM4R
Copy link
Contributor

@0oM4R 0oM4R commented Oct 24, 2024

Description

allow underscore in dashboard k8s validations

Changes

add IsAlphanumericExpectUnderscore to all k8s models and addMachineModel

Related Issues

Tested Scenarios

with underscore in the name

  • attache caprover worker, delete it
  • create k8s cluster, add worker, delete worker, delete cluster
    Screenshot from 2024-10-24 15-32-37
    Screenshot from 2024-10-24 15-11-46
    Screenshot from 2024-10-24 15-03-41

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

allow undersocre in dashboard k8s validations
@0oM4R 0oM4R merged commit a78daae into development Oct 28, 2024
10 checks passed
@0oM4R 0oM4R deleted the development_orchestrators_name branch October 28, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants