Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable clear btn in invalid form #3560

Merged
merged 3 commits into from
Oct 29, 2024
Merged

Enable clear btn in invalid form #3560

merged 3 commits into from
Oct 29, 2024

Conversation

amiraabouhadid
Copy link
Contributor

Changes

  • remove valid condition in clear btn

Related Issues

#3521

Tested Scenarios

  • entered an invalid farm id in node finder, was able to clear invalid form
  • entered an invalid ip in farm finder, was able to clear invalid form

Checklist

@amiraabouhadid amiraabouhadid marked this pull request as ready for review October 29, 2024 08:04
@amiraabouhadid amiraabouhadid merged commit bde23e3 into development_2.7 Oct 29, 2024
6 checks passed
@amiraabouhadid amiraabouhadid deleted the dev_enable_clear_invalid_form branch October 29, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samaradel samaradel samaradel approved these changes

@AhmedHanafy725 AhmedHanafy725 Awaiting requested review from AhmedHanafy725 AhmedHanafy725 is a code owner

@zaelgohary zaelgohary Awaiting requested review from zaelgohary zaelgohary is a code owner

@maayarosama maayarosama Awaiting requested review from maayarosama maayarosama is a code owner

@MohamedElmdary MohamedElmdary Awaiting requested review from MohamedElmdary MohamedElmdary is a code owner

@Mahmoud-Emad Mahmoud-Emad Awaiting requested review from Mahmoud-Emad Mahmoud-Emad is a code owner

@AlaaElattar AlaaElattar Awaiting requested review from AlaaElattar AlaaElattar is a code owner

@0oM4R 0oM4R Awaiting requested review from 0oM4R 0oM4R is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amiraabouhadid @samaradel