Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authorization confirmation modal updates #274

Merged
merged 4 commits into from
Oct 25, 2022

Conversation

r-czajkowski
Copy link
Collaborator

Closes: #253

This PR updates the authorization confirmation modal. Main changes are:

  • adds missing word app in the staking app card,
  • fixes typo RANDOMBEACON -> RANDOM BEACON,
  • adds missing denominator- next to the amount of T authorized the T denominator should be displayed.

Add missing word `app` in the staking app card.

Fix typo `RANDOMBEACON -> RANDOM BEACON`.
Add missing denominator- next to the amount of T authorized the T
denominator should be displayed.
@github-actions
Copy link

Copy link
Contributor

@michalsmiarowski michalsmiarowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one small comment but overall looking good 👍

In ea991e we added a function that returns the app label based on the
staking app type. This commit uses this function instead of a custom
map.
@github-actions
Copy link

Copy link
Contributor

@michalsmiarowski michalsmiarowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎸

@michalsmiarowski michalsmiarowski merged commit 7a20890 into main Oct 25, 2022
@michalsmiarowski michalsmiarowski deleted the auth-confirmation-modal-updates branch October 25, 2022 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Authorization Confirm modal needs some updates
2 participants