Builds the usability survey page #315
Conversation
|
Preview uploaded to https://preview.dashboard.test.threshold.network/usability-survey/index.html. |
georgeweiler
changed the title
georgeweiler
changed the title
…nto usability-survey
|
Preview uploaded to https://preview.dashboard.test.threshold.network/usability-survey/index.html. |
…nto usability-survey
…oken-dashboard into usability-survey
|
Preview uploaded to https://preview.dashboard.test.threshold.network/usability-survey/index.html. |
|
Preview uploaded to https://preview.dashboard.test.threshold.network/usability-survey/index.html. |
| {range(numberOfButtons, 1).map((n) => ( | ||
| <Button | ||
| size={size} | ||
| variant="sequence" |
There was a problem hiding this comment.
Let's bump the components package- the PR that adds new variant has been merged threshold-network/components#37.
There was a problem hiding this comment.
@r-czajkowski doesn't the development version cover this case? Is it just a yarn.lock update we need? or do you suggest we install "@threshold-network/components": "^1.0.0-dev.0",?
| rows.map((row) => { | ||
| if (row.id === rowId) { | ||
| return { | ||
| ...row, | ||
| value, | ||
| } | ||
| } | ||
| return row | ||
| }) | ||
| ) |
There was a problem hiding this comment.
Can we simplify?
setRows(rows => rows.map(row => row.id === rowId ? { ...row, value } : row))
|
Preview uploaded to https://preview.dashboard.test.threshold.network/usability-survey/index.html. |
| import { FC } from "react" | ||
| import { Button, HStack } from "@threshold-network/components" | ||
| import { range } from "../utils/range" | ||
| import { StackProps } from "@chakra-ui/react" |
There was a problem hiding this comment.
Can we import from @threshold-network/components?
| numberOfButtons: number | ||
| selectedButtonNum?: number | ||
| onButtonClick: (n: number) => void | ||
| size?: ThemeTypings["components"]["Button"]["sizes"] |
There was a problem hiding this comment.
I think we can ButtonProps["size"] and import the ButtonProps from @threshold-network/components
| Tr, | ||
| } from "@threshold-network/components" | ||
| import { Row, RowID, RowValue } from "./types" | ||
| import { useColorModeValue } from "@chakra-ui/react" |
There was a problem hiding this comment.
Let's import from @threshold-network/components.
| value, | ||
| })) | ||
|
|
||
| console.log("Payload ", payload) |
There was a problem hiding this comment.
Do we need console.log?
There was a problem hiding this comment.
I can remove it. just added to prevent an unused var warning. I still need to implement the post function, but waiting for code from other branches.
Builds the usability survey form. There are a few TODOs to implement in future pull requests: