Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spelling of isDeauthorizationReqestActive #658

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

theref
Copy link
Member

@theref theref commented Nov 13, 2023

isDeauthorizationReqestActive -> isDeauthorizationRequestActive

Copy link
Contributor

@michalsmiarowski michalsmiarowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments to look at before the merge.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Unrelated to the file]

Let's also change this typo in those two places:

and

Without those changes the error appears here:

tbtc: {
...tbtcApp,
stakingAppId: "tbtc",
address: tbtcAppAddress,
label: "tBTC",
},
randomBeacon: {
...randomBeaconApp,
stakingAppId: "randomBeacon",
address: randomBeaconAddress,
label: "Random Beacon",
},

@@ -148,7 +148,7 @@ const getKeepStakingAppStakingProvidersData = async (
_appData.pendingAuthorizationDecrease.toString(),
remainingAuthorizationDecreaseDelay:
_appData.remainingAuthorizationDecreaseDelay.toString(),
isDeauthorizationReqestActive: _appData.isDeauthorizationReqestActive,
isDeauthorizationRequestActive: _appData.isDeauthorizationRequestActive,
Copy link
Contributor

@michalsmiarowski michalsmiarowski Nov 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The builds are failing because code is not formatted. Please run yarn format:fix to fix that.

If you do that (and just that) in a separate commit, then additionaly add that commit hash to .git-blame-ignore-revs file.

@@ -21,3 +21,5 @@ cypress/plugins
# Yarn
node_modules/
yarn-error.log

.cosine/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this directory? 🤔

@@ -59,7 +59,7 @@ export interface StakingProviderAppInfo<
* call `joinSortitionPool` or `updateOperatorStatus` to activate the request.
* In that case we can't estimate when the deauthorization request started.
*/
isDeauthorizationReqestActive: boolean
isDeauthorizationRequestActive: boolean
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we are at it, let's also fix the similar typo in the comment above:

* `MAX_UINT64` the deauthorization reqest is pending and an operator have to

@@ -321,21 +321,21 @@ export class Application implements IApplication {
remainingAuthorizationDecreaseDelay.toString()
)

let isDeauthorizationReqestActive = true
let isDeauthorizationRequestActive = true
if (_remainingAuthorizationDecreaseDelay.eq(MAX_UINT64)) {
// If a `remainingAuthorizationDecreaseDelay` is equal `MAX_UINT64` the
// deauthorization reqest is pending and an operator have to call
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also fix a similar typo in this comment

Suggested change
// deauthorization reqest is pending and an operator have to call
// deauthorization request is pending and an operator have to call

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants