feat(gogocode-plugin-prettier): support to format code by config file #168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hytor-yang
reviewed
Dec 20, 2023
| parser: /\.vue$/.test(fileInfo.path) ? 'vue' : 'typescript', | ||
| }); | ||
| }; | ||
| const { prettierrc, rootPath } = options |
There was a problem hiding this comment.
for the command gogocode -s dir/input.js -t gogocode-plugin-prettier -o dir/output.js -p prettierrc=.prettierrc.json, rootPath value here would be dir instead of current working directory.
Probably options.pwdPath makes more sense?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
这个PR是用于解决
gogocode-plugin-prettier无法自定义配置项的问题。对此提供了一个加载prettier配置文件的功能。
This PR is to solve the problem that
gogocode-plugin-prettiercannot customize code format style.Now provide a feature that support to load a prettier configuration file.
API
Fixes
#166