Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed & search after consuming parenthesis #322

Merged
merged 4 commits into from
Dec 27, 2023
Merged

Fixed & search after consuming parenthesis #322

merged 4 commits into from
Dec 27, 2023

Conversation

Andarist
Copy link
Collaborator

fixes #321

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 22, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 7333462077

  • 4 of 4 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 98.887%
Totals Coverage Status
Change from base Build 6108664341: 0.003%
Covered Lines: 284
Relevant Lines: 286
💛 - Coveralls

Andarist
Andarist commented Dec 22, 2023
View reviewed changes
src/Parser.js Show resolved Hide resolved
Andarist
Andarist commented Dec 22, 2023
View reviewed changes
src/Parser.js Outdated Show resolved Hide resolved
@Andarist
Copy link
Collaborator Author

@thysultan would you mind taking another look at this?

@Andarist
Copy link
Collaborator Author

I think this is ready to be merged in now - but a final confirmation would be highly appreciated :)

@quantizor
Copy link
Contributor

quantizor commented Dec 27, 2023 •
edited
Loading

@Andarist could you cut a test build so I can cross-check? Thank you for taking this on!

@Andarist
Copy link
Collaborator Author

@quantizor I don't quite want to go through this hassle right now. Would you be willing to try this out through npm link or similar?

@Andarist Andarist merged commit 3b9b321 into master Dec 27, 2023
2 checks passed
@Andarist Andarist deleted the fix/321 branch December 27, 2023 18:31
@quantizor
Copy link
Contributor

Thank you both!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thysultan thysultan thysultan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Namespace omitted for comma-joined selectors in some scenarios
3 participants
@Andarist @quantizor @thysultan