Merge pull request #372 from t0chk/master

Update futures rest-client
tiagosiebler · Nov 24, 2023 · 11e5f2d · 11e5f2d
2 parents d7fea65 + 4c1ef70
commit 11e5f2d
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 5 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "binance",
-  "version": "2.8.12",
+  "version": "2.8.13",
   "description": "Node.js & JavaScript SDK for Binance REST APIs & WebSockets, with TypeScript & end-to-end tests.",
   "main": "lib/index.js",
   "types": "lib/index.d.ts",

diff --git a/src/coinm-client.ts b/src/coinm-client.ts
@@ -71,6 +71,7 @@ import {
   OrderAmendment,
   FuturesCoinMAccountBalance,
   FuturesCoinMAccountInformation,
+  UserCommissionRate,
 } from './types/futures';
 
 import {
@@ -426,7 +427,7 @@ export class CoinMClient extends BaseRestClient {
 
   getAccountComissionRate(
     params: BasicSymbolParam,
-  ): Promise<RebateDataOverview> {
+  ): Promise<UserCommissionRate> {
     return this.getPrivate('dapi/v1/commissionRate', params);
   }
 

diff --git a/src/types/futures.ts b/src/types/futures.ts
@@ -610,7 +610,7 @@ export interface FuturesAccountInformation {
 }
 
 export interface FuturesCoinMAccountInformation {
-  assets: Omit<FuturesAccountAsset, 'marginAvailable' | 'updateTime'>[];
+  assets: Omit<FuturesAccountAsset, 'marginAvailable'>[];
   positions: FuturesCoinMAccountPosition[];
   canTrade: boolean;
   canDeposit: boolean;
@@ -691,6 +691,12 @@ export interface SymbolLeverageBracketsResult {
   brackets: SymbolLeverageBracket[];
 }
 
+export interface UserCommissionRate {
+  symbol: string;
+  makerCommissionRate: numberInString;
+  takerCommissionRate: numberInString;
+}
+
 export interface RebateDataOverview {
   brokerId: string;
   newTraderRebateCommission: numberInString;

diff --git a/src/usdm-client.ts b/src/usdm-client.ts
@@ -65,6 +65,7 @@ import {
   ChangeStats24hr,
   MarkPrice,
   HistoricOpenInterest,
+  UserCommissionRate,
 } from './types/futures';
 
 import {
@@ -381,7 +382,7 @@ export class USDMClient extends BaseRestClient {
   }
 
   getAccountTrades(
-    params: SymbolFromPaginatedRequestFromId,
+    params: SymbolFromPaginatedRequestFromId & { orderId?: number },
   ): Promise<FuturesPositionTrade[]> {
     return this.getPrivate('fapi/v1/userTrades', params);
   }
@@ -415,7 +416,7 @@ export class USDMClient extends BaseRestClient {
 
   getAccountComissionRate(
     params: BasicSymbolParam,
-  ): Promise<RebateDataOverview> {
+  ): Promise<UserCommissionRate> {
     return this.getPrivate('fapi/v1/commissionRate', params);
   }