v2.10.1: fix(#402) update ms passthru

tiagosiebler · Feb 14, 2024 · 6ce592f · 6ce592f
1 parent 58727ff
commit 6ce592f
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 5 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "binance",
-  "version": "2.10.0",
+  "version": "2.10.1",
   "description": "Node.js & JavaScript SDK for Binance REST APIs & WebSockets, with TypeScript & end-to-end tests.",
   "main": "lib/index.js",
   "types": "lib/index.d.ts",

diff --git a/src/websocket-client.ts b/src/websocket-client.ts
@@ -1583,7 +1583,9 @@ export class WebsocketClient extends EventEmitter {
     const lowerCaseSymbol = symbol.toLowerCase();
     const streamName = 'depth';
     const wsKey = getWsKeyWithContext(market, streamName, lowerCaseSymbol);
-    const updateMsSuffx = updateMs === 100 ? `@${updateMs}ms` : '';
+
+    const updateMsSuffx = typeof updateMs === 'number' ? `@${updateMs}ms` : '';
+
     return this.connectToWsUrl(
       this.getWsBaseUrl(market, wsKey) +
         `/ws/${lowerCaseSymbol}@${streamName}${levels}${updateMsSuffx}`,
@@ -1599,6 +1601,8 @@ export class WebsocketClient extends EventEmitter {
    *
    * - Spot: https://binance-docs.github.io/apidocs/spot/en/#diff-depth-stream
    * - USDM Futures: https://binance-docs.github.io/apidocs/futures/en/#diff-book-depth-streams
+   *
+   * Use getContextFromWsKey(data.wsKey) to extract symbol from events
    */
   public subscribeDiffBookDepth(
     symbol: string,
@@ -1614,7 +1618,9 @@ export class WebsocketClient extends EventEmitter {
       lowerCaseSymbol,
       String(updateMs),
     );
-    const updateMsSuffx = updateMs === 100 ? `@${updateMs}ms` : '';
+
+    const updateMsSuffx = typeof updateMs === 'number' ? `@${updateMs}ms` : '';
+
     return this.connectToWsUrl(
       this.getWsBaseUrl(market, wsKey) +
         `/ws/${lowerCaseSymbol}@${streamName}${updateMsSuffx}`,