fix(v2.15.14): fixes #527 issue with max order ID length from portfol…

…io margin, fixes #523 & #526 issue with number handling from multiple orders endpoint

package.json

@@ -1,6 +1,6 @@
 {
   "name": "binance",
-  "version": "2.15.13",
+  "version": "2.15.14",
   "description": "Node.js & JavaScript SDK for Binance REST APIs & WebSockets, with TypeScript & end-to-end tests.",
   "main": "lib/index.js",
   "types": "lib/index.d.ts",

src/usdm-client.ts

@@ -80,6 +80,7 @@ import {
   Kline,
   KlinesParams,
   NewOCOParams,
+  numberInString,
   OrderBookParams,
   OrderIdProperty,
   RecentTradesParams,
@@ -318,15 +319,29 @@ export class USDMClient extends BaseRestClient {
   }
 
   /**
-   * Warning: max 5 orders at a time! This method does not throw, instead it returns individual errors in the response array if any orders were rejected.
+   * Warning: max 5 orders at a time! This method does not throw, instead it returns
+   * individual errors in the response array if any orders were rejected.
    *
-   * Known issue: `quantity` and `price` should be sent as strings
+   * Note: this method will automatically ensure "price" and "quantity" are sent as a
+   * string, if present in the request. See #523 & #526 for more details.
    */
-  submitMultipleOrders<TNumberType = number>(
+  submitMultipleOrders<TNumberType = numberInString>(
     orders: NewFuturesOrderParams<TNumberType>[],
   ): Promise<(NewOrderResult | NewOrderError)[]> {
     const stringOrders = orders.map((order) => {
       const orderToStringify = { ...order };
+
+      // Known issue: `quantity` and `price` should be sent as strings, see #523, #526
+      const price = orderToStringify['price'];
+      if (price && typeof price == 'number') {
+        orderToStringify['price'] = `${price}` as TNumberType;
+      }
+
+      const quantity = orderToStringify['quantity'];
+      if (quantity && typeof quantity == 'number') {
+        orderToStringify['quantity'] = `${quantity}` as TNumberType;
+      }
+
       this.validateOrderId(orderToStringify, 'newClientOrderId');
       return JSON.stringify(orderToStringify);
     });

src/util/requestUtils.ts

@@ -88,7 +88,7 @@ export function getOrderIdPrefix(network: BinanceBaseUrlKey): string {
 }
 
 export function generateNewOrderId(network: BinanceBaseUrlKey): string {
-  const id = nanoid(25);
+  const id = nanoid(22);
   const prefixedId = 'x-' + getOrderIdPrefix(network) + id;
 
   return prefixedId;