feat(v2.15.4, #505): Add goodTillDate futures order property
#506
+3
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siegfried
commented
Jan 28, 2025
src/types/futures.ts
Outdated
| @@ -851,14 +852,14 @@ export interface ModifyOrderParams { | |||
| quantity: string; | |||
| price: string; | |||
| priceMatch?: | |||
| | 'OPPONENT' | |||
There was a problem hiding this comment.
Formatted by the language server...
There was a problem hiding this comment.
This was automatically changed by your editor? I have eslint configured to run on-save, but you can run it manually on only this file using this command:
npx eslint --fix src/types/futures.ts
That should correct the formatting here
tiagosiebler
requested changes
Jan 28, 2025
siegfried
commented
Jan 29, 2025
| } |
There was a problem hiding this comment.
Language server did this again. Hope you don't mind.
There was a problem hiding this comment.
This is fine, as long as eslint is happy - otherwise one of the build steps will fail
|
Updated. Please review. Thanks. |
tiagosiebler
changed the title
goodTillDategoodTillDate futures order property
tiagosiebler
changed the title
goodTillDate futures order propertygoodTillDate futures order property
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add
goodTillDatementioned in #505