manager: hides navbar on action screen, disable back gesture and save… #2321
Conversation
… logs until action is completed - This is to avoid this issue #2315 of irresponsive behaviour of runModuleAction() in ui.util.KsuCli which executes shell commands, in that process if a transition is made to a different Destination i.e HomeScreen it will get stuck until the action is completed or app crashes.
screen-20241226-234953.mp4 |
|
I like this change this will also remove the need for modules to add that nasty sleep pause at exit screen-20241227-090543.webm |
|
I like this change too but, there seems to be a small problem. I think it should exit automatically after execution instead of being closed manually. Screenrecorder-2024-12-27-10-23-18-651.mp4 |
literally defeats the purpose of getting rid of sleep in scripts |
in preparation of tiann/KernelSU#2321
|
Hold this PR, there is a minor issues with navigation bar
|
|
Sike! Already fixed... screen-20241229-131039.webm |
| val date = format.format(Date()) | ||
| val file = File( | ||
| Environment.getExternalStoragePublicDirectory(Environment.DIRECTORY_DOWNLOADS), | ||
| "KernelSU_Next_module_action_log_${date}.log" |
There was a problem hiding this comment.
Remove the Next here?
There was a problem hiding this comment.
Lmao I forgot to get rid of it, it's from my branch xD
| } | ||
| }, | ||
| modifier = Modifier | ||
| .navigationBarsPadding() |
There was a problem hiding this comment.
I think change the contentWindowInsets (line 131 for now ) to WindowInsets.safeDrawing without only(WindowInsetsSides.Top + WindowInsetsSides.Horizontal) will be better
There was a problem hiding this comment.
For the system to decide? Sure
There was a problem hiding this comment.
But the positioning for vertical is a bit off for my personal taste, are you okay with it?
There was a problem hiding this comment.
Remove modifier = Modifier.navigationBarsPadding() pls
We needn't that because Scaffold has already added the navigation bar insets
There was a problem hiding this comment.
Remove
modifier = Modifier.navigationBarsPadding()pls We needn't that becauseScaffoldhas already added the navigation bar insets
It was for when WindowInsets.safeDrawing without only(WindowInsetsSides.Top + WindowInsetsSides.Horizontal) was there and the button would be behind the nav bar, so since it's removed I can just get rid of the modifier = Modifier.navigationBarsPadding() sure
|
Good to go |
… the navigation bar insets
|
Merge before 2025?? |
… logs until action is completed Fix irresponsive behaviour of runModuleAction() in ui.util.KsuCli to avoid app crash or hang during transition (tiann#2321).
… logs until action is completed Fix irresponsive behaviour of runModuleAction() in ui.util.KsuCli to avoid app crash or hang during transition (tiann#2321)
… logs until action is completed Fix irresponsive behaviour of runModuleAction() in ui.util.KsuCli to avoid app crash or hang during transition (tiann#2321)
… logs until action is completed Fix irresponsive behaviour of runModuleAction() in ui.util.KsuCli to avoid app crash or hang during transition (tiann#2321)
… logs until action is completed Fix irresponsive behaviour of runModuleAction() in ui.util.KsuCli to avoid app crash or hang during transition (tiann#2321)
… logs until action is completed Fix irresponsive behaviour of runModuleAction() in ui.util.KsuCli to avoid app crash or hang during transition (tiann#2321)
… logs until action is completed