Add generators for SMBIOS type 4 and 7 tables (CPU and cache topologies) #517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing field is x86 only. Re-typedef for AArch64. Signed-off-by: Sarah Walker <[email protected]>
sarah-walker-arm
force-pushed
the
dynamictables-reorg-3735_SMBIOS_Type4_7
branch
from
015e806 to
0b071af
Compare
DynamicTablesPkg/Library/Smbios/SmbiosType7Lib/SmbiosType7Generator.c
Outdated
Show resolved
Hide resolved
Abstract tokens simplify linking of generated tables. They allow for tables to be search for not just by existing ConfigurationManager object references, but also by arbitary tokens generated by the table generators themselves. Signed-off-by: Sarah Walker <[email protected]>
These are used by the Type 7 generator. Signed-off-by: Sarah Walker <[email protected]>
sarah-walker-arm
force-pushed
the
dynamictables-reorg-3735_SMBIOS_Type4_7
branch
from
0b071af to
9a654b5
Compare
DynamicTablesPkg/Library/Smbios/SmbiosType7Lib/SmbiosType7Lib.inf
Outdated
Show resolved
Hide resolved
DynamicTablesPkg/Library/Smbios/SmbiosType7Lib/SmbiosType7Lib.inf
Outdated
Show resolved
Hide resolved
DynamicTablesPkg/Library/Smbios/SmbiosType7Lib/SmbiosType7Generator.c
Outdated
Show resolved
Hide resolved
DynamicTablesPkg/Library/Smbios/SmbiosType4Lib/SmbiosType4Generator.c
Outdated
Show resolved
Hide resolved
DynamicTablesPkg/Library/Smbios/SmbiosType4Lib/SmbiosType4Generator.c
Outdated
Show resolved
Hide resolved
DynamicTablesPkg/Library/Smbios/SmbiosType4Lib/SmbiosType4Generator.c
Outdated
Show resolved
Hide resolved
DynamicTablesPkg/Library/Smbios/SmbiosType4Lib/SmbiosType4Generator.c
Outdated
Show resolved
Hide resolved
sarah-walker-arm
force-pushed
the
dynamictables-reorg-3735_SMBIOS_Type4_7
branch
from
9a654b5 to
114480f
Compare
|
Hi Sarah, |
sarah-walker-arm
force-pushed
the
dynamictables-reorg-3735_SMBIOS_Type4_7
branch
from
114480f to
6a95740
Compare
DynamicTablesPkg/Library/Smbios/SmbiosType7Lib/SmbiosType7Generator.c
Outdated
Show resolved
Hide resolved
DynamicTablesPkg/Library/Smbios/SmbiosType7Lib/SmbiosType7Generator.c
Outdated
Show resolved
Hide resolved
sarah-walker-arm
force-pushed
the
dynamictables-reorg-3735_SMBIOS_Type4_7
branch
2 times, most recently
from
3894972 to
a71fb7c
Compare
|
Some final comments:
|
Signed-off-by: Sarah Walker <[email protected]>
Signed-off-by: Sarah Walker <[email protected]>
BuildAndInstallMultipleSmbiosTables() can dereference a NULL pointer if the SMBIOS table builder returns a NULL CmObjToken array. Signed-off-by: Sarah Walker <[email protected]>
Implement a support library for SMBIOS-related SMC calls. Currently this implements a function to return the SoC ID. Signed-off-by: Sarah Walker <[email protected]>
Update ProcessorSubClassDxe to handle the new cache size and AArch64 PROCESSOR_ID_DATA SMBIOS structures. Signed-off-by: Sarah Walker <[email protected]>
sarah-walker-arm
force-pushed
the
dynamictables-reorg-3735_SMBIOS_Type4_7
branch
from
fda387a to
3a39bb7
Compare
pierregondois
approved these changes
Jul 22, 2025
samimujawar
approved these changes
Jul 22, 2025
samimujawar
merged commit baf5fb7
into
tianocore:dynamictables-reorg
1 of 2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.