Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RedfishPkg: Populate serial number in SMBIOS type 42 record #10818

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

RedfishPkg: Populate serial number in SMBIOS type 42 record #10818

wants to merge 9 commits into from
+97 −2

Conversation

thejaputta
Copy link
Contributor

No description provided.

@thejaputta thejaputta force-pushed the Populate_SMBIOS_T42_UsbSerialNum branch from b663ec2 to b2c6240 Compare March 5, 2025 00:51
igorkulchytskyy
igorkulchytskyy approved these changes Mar 6, 2025
View reviewed changes
Copy link
Contributor

@igorkulchytskyy igorkulchytskyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me

@thejaputta thejaputta force-pushed the Populate_SMBIOS_T42_UsbSerialNum branch from 994a309 to 0e9e938 Compare March 6, 2025 20:26
@thejaputta
Copy link
Contributor Author

Hi, all failing CI checks are related to "SpellCheck failing for 99 words". Those failing words are not related to this change. Any suggestions on how to handle this issue?

@mdkinney
Copy link
Member

The spelling checks are in log, but does not fail CI. The real error is above those messages in the log:

PROGRESS - Running Build RELEASE
ERROR - Compiler #2220 from D:\a\1\s\RedfishPkg\RedfishHostInterfaceDxe\RedfishHostInterfaceDxe.c(97): the following warning is treated as an error
WARNING - Compiler #4244 from D:\a\1\s\RedfishPkg\RedfishHostInterfaceDxe\RedfishHostInterfaceDxe.c(97): '=': conversion from 'UINTN' to 'UINT8', possible loss of data
ERROR - Compiler #1077 from NMAKE : fatal '"C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.43.34808\bin\Hostx86\x86\cl.exe" /FoD:\a\1\s\Build\RedfishPkg\RELEASE_VS2022\IA32\RedfishPkg\RedfishHostInterfaceDxe\RedfishHostInterfaceDxe\OUTPUT\.\ /showIncludes /nologo /arch:IA32 /c /WX /GS /W4 /Gs32768 /D UNICODE /O1b2 /GL /FIAutoGen.h /EHs-c- /GR- /GF /Gw /ID:\a\1\s\RedfishPkg\RedfishHostInterfaceDxe  /ID:\a\1\s\Build\RedfishPkg\RELEASE_VS2022\IA32\RedfishPkg\RedfishHostInterfaceDxe\RedfishHostInterfaceDxe\DEBUG  /ID:\a\1\s\MdePkg  /ID:\a\1\s\MdePkg\Include  /ID:\a\1\s\MdePkg\Test\UnitTest\Include  /ID:\a\1\s\MdePkg\Test\Mock\Include  /ID:\a\1\s\MdePkg\Library\MipiSysTLib\mipisyst\library\include  /ID:\a\1\s\MdePkg\Include\Ia32  /ID:\a\1\s\MdeModulePkg  /ID:\a\1\s\MdeModulePkg\Include  /ID:\a\1\s\MdeModulePkg\Test\Mock\Include  /ID:\a\1\s\RedfishPkg  /ID:\a\1\s\RedfishPkg\Include  /ID:\a\1\s\RedfishPkg\PrivateInclude\Crt  /ID:\a\1\s\RedfishPkg\Library\JsonLib  /ID:\a\1\s\RedfishPkg\Library\JsonLib\jansson\src @D:\a\1\s\Build\RedfishPkg\RELEASE_VS2022\IA32\RedfishPkg\RedfishHostInterfaceDxe\RedfishHostInterfaceDxe\OUTPUT\cc_resp_1.txt' : return code '0x2'
ERROR - Compiler #7000 from : Failed to execute command
ERROR - EDK2 #002 from : Failed to build module
CRITICAL - Build failed

@thejaputta
RedfishPkg: Populate serial number in SMBIOS type 42 record
7d2ffa3 
Add a stub function to read host interface USB serial number,
append serial number to SMBIOS type 42 record if valid data
is returned.

Signed-off-by: Thejaswani Putta <[email protected]>
@thejaputta
Update function name to adhere to EDK2 coding conventions
4a5d792 
Signed-off-by: Thejaswani Putta <[email protected]>
@thejaputta
Add a check to verify the serial number string length
eca7185 
Signed-off-by: Thejaswani Putta <[email protected]>
@thejaputta
use local variable to avoid calling strlen twice
1d9057d 
Signed-off-by: Thejaswani Putta <[email protected]>
@thejaputta
define UINT8_MAX
cd663bc 
Signed-off-by: Thejaswani Putta <[email protected]>
@thejaputta
Replace UINT8_MAX constant with standard MAX_UINT8 definition from Ba…
8d2942d 
…se.h

Signed-off-by: Thejaswani Putta <[email protected]>
@thejaputta
Add stub implementation and initilize values appropriately.
acaba53 
Signed-off-by: Thejaswani Putta <[email protected]>
@thejaputta
Rename function to be more generic
3e0a147 
Signed-off-by: Thejaswani Putta <[email protected]>
@thejaputta thejaputta force-pushed the Populate_SMBIOS_T42_UsbSerialNum branch from c321bcf to 3e0a147 Compare March 19, 2025 00:57
@thejaputta
Copy link
Contributor Author

It looks like the tianocore.PatchCheck passed all checks for each individual commit. However, the pipeline still failed. Any suggestions on how to get it fixed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicklela nicklela nicklela approved these changes

@mdkinney mdkinney mdkinney left review comments

@changab changab changab left review comments

@igorkulchytskyy igorkulchytskyy igorkulchytskyy approved these changes

@ghbaccount ghbaccount ghbaccount left review comments

@ajfish ajfish Awaiting requested review from ajfish

@makubacki makubacki Awaiting requested review from makubacki

@niruiyu niruiyu Awaiting requested review from niruiyu

@os-d os-d Awaiting requested review from os-d

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@thejaputta @mdkinney @nicklela @changab @igorkulchytskyy @ghbaccount