DynamicTablesPkg: Add support for non-serial DBG2 devices

[jbrasen]

Description

This commit adds support for building non-serial DBG2 devices

1. Add new common namespace objects:

   • EArchCommonObjMemoryRangeDescriptor
   • EArchCommonObjDbg2DeviceInfo

2. Enhance DBG2 table generator:

   • Add support for non-serial DBG2 devices
   • Support multiple debug devices
   • Improve memory handling with proper allocation checks
   • Add better cleanup in error paths

3. Update configuration manager:

   • Add parsers for new common namespace objects

• Breaking change?
• Impacts security?
• Includes tests?

How This Was Tested

Created config manager object for a PCIe NIC and validated the DBG2 node. Added HostBasedTest for this library

Integration Instructions

N/A

[jbrasen]

@pierregondois I think all the review feedback was updated. I also added a host based test for this.

[pierregondois]

Hello Jeff,
Thanks for adding the test file.

@samimujawar as this is new to the package, would it be ok to check it the GoogleTest file if you're ok with it ?

Regards,
Pierre

[samimujawar]

Hello Jeff, Thanks for adding the test file.

@samimujawar as this is new to the package, would it be ok to check it the GoogleTest file if you're ok with it ?

Regards, Pierre

@jbrasen Thanks a lot for introducing these tests. This is indeed a good initiative.
Unfortunately, I have not looked into detail on how these tests are supposed to be designed/created.
If you can add a section to the DynamicTablesPkg/Readme.md on how these tests can be built & run, it would be of great help for us to explore further.
For now I think we could go ahead with your implementation, but we would be keen to build on this further and improve the testing for this package.

[pierregondois]

Just one minor comment, otherwise lgtm.
The serial port information generated for Juno/kvmtool didn't change. I didn't try to create non-serial ports but the code looked correct.

Just need to check with @samimujawar if this is ok to include GoogleTests

[samimujawar]

Just one minor comment, otherwise lgtm. The serial port information generated for Juno/kvmtool didn't change. I didn't try to create non-serial ports but the code looked correct.

Just need to check with @samimujawar if this is ok to include GoogleTests

I think adding GoogleTests is good. We need to see how GoogleTests can be supported other generators as well.

[NicholasGraves]

Just one minor comment, otherwise lgtm. The serial port information generated for Juno/kvmtool didn't change. I didn't try to create non-serial ports but the code looked correct.
Just need to check with @samimujawar if this is ok to include GoogleTests

I think adding GoogleTests is good. We need to see how GoogleTests can be supported other generators as well.

I'm adding a DynamicTables generator for CEDT right now and I'm using the same pattern as this PR for gtests. Intercepting the table registration makes implementing the rest of the test mostly straightforward.

[mergify]

queue

🟠 Waiting for conditions to match

Details

• -closed [📌 queue requirement]
• any of: [🔀 queue conditions]
  • all of: [📌 queue conditions of queue default]
    • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
    • #approved-reviews-by >= 1 [🛡 GitHub branch protection]
    • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
    • base~=(^main|^master|^stable/)
    • label=push
    • any of: [🛡 GitHub branch protection]
      • check-success = tianocore.PatchCheck
      • check-neutral = tianocore.PatchCheck
      • check-skipped = tianocore.PatchCheck
    • any of: [🛡 GitHub branch protection]
      • check-success = ArmVirtPkg - Ubuntu GCC - PR
      • check-neutral = ArmVirtPkg - Ubuntu GCC - PR
      • check-skipped = ArmVirtPkg - Ubuntu GCC - PR
    • any of: [🛡 GitHub branch protection]
      • check-success = EmulatorPkg - Ubuntu GCC - PR
      • check-neutral = EmulatorPkg - Ubuntu GCC - PR
      • check-skipped = EmulatorPkg - Ubuntu GCC - PR
    • any of: [🛡 GitHub branch protection]
      • check-success = EmulatorPkg - Windows VS - PR
      • check-neutral = EmulatorPkg - Windows VS - PR
      • check-skipped = EmulatorPkg - Windows VS - PR
    • any of: [🛡 GitHub branch protection]
      • check-success = OvmfPkg - Ubuntu GCC - PR
      • check-neutral = OvmfPkg - Ubuntu GCC - PR
      • check-skipped = OvmfPkg - Ubuntu GCC - PR
    • any of: [🛡 GitHub branch protection]
      • check-success = OvmfPkg - Windows VS - PR
      • check-neutral = OvmfPkg - Windows VS - PR
      • check-skipped = OvmfPkg - Windows VS - PR
    • any of: [🛡 GitHub branch protection]
      • check-success = Windows VS - PR
      • check-neutral = Windows VS - PR
      • check-skipped = Windows VS - PR
    • any of: [🛡 GitHub branch protection]
      • check-success = Ubuntu GCC - PR
      • check-neutral = Ubuntu GCC - PR
      • check-skipped = Ubuntu GCC - PR
• -conflict [📌 queue requirement]
• -draft [📌 queue requirement]
• any of: [📌 queue -> configuration change requirements]
  • -mergify-configuration-changed
  • check-success = Configuration changed