Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PrmPkg: Correct the flags for GCC compiler #10875

Merged
merged 1 commit into from
Mar 27, 2025
Merged

Conversation

abdattar
Copy link
Contributor

Description

Correct the GCC GenFw and ld flag to build PRM run time modules.
These changes are made for X64 GCC compiler, current present for AARCH64 only.

  • Breaking change?
    • Breaking change - Does this PR cause a break in build or boot behavior?
    • Examples: Does it add a new library class or move a module to a different repo.
  • Impacts security?
    • Security - Does this PR have a direct security impact?
    • Examples: Crypto algorithm change or buffer overflow fix.
  • Includes tests?
    • Tests - Does this PR include any explicit test code?
    • Examples: Unit tests or integration tests.

How This Was Tested

Build on Ubuntu environment

Integration Instructions

N/A

@tianocore-assign-reviewers
Copy link

WARNING: Cannot add some reviewers: A user specified as a reviewer for this PR is not a collaborator of the repository. Please add them as a collaborator to the repository so they can be requested in the future.

Non-collaborators requested:

Attn Admins:


Admin Instructions:

  • Add the non-collaborators as collaborators to the appropriate team(s) listed in teams
  • If they are no longer needed as reviewers, remove them from Maintainers.txt

@abdattar
Copy link
Contributor Author

opened issue for the failure.
#10876

@nate-desimone
Copy link
Member

Please check and fix the CI failures. Otherwise the code change looks good!

@abdattar
Copy link
Contributor Author

Please check and fix the CI failures. Otherwise the code change looks good!

Looks like basetool issue and i opened the issue to address the same.
#10876

@makubacki
Copy link
Member

@abdattar, thank you for the change and addressing the PR comments. If someone doesn't pick up the BaseTool change needed by next week, I'll take a look.

@abdattar
Copy link
Contributor Author

Fix the build failure by adding below build option to retain the symbols
GCC:__X64_OBJCOPY_STRIPFLAG = --keep-symbol=PrmModuleExportDescriptor --keep-symbol=CheckParamBufferPrmHandler

@makubacki
Copy link
Member

Fix the build failure by adding below build option to retain the symbols GCC:____X64_OBJCOPY_STRIPFLAG = --keep-symbol=PrmModuleExportDescriptor --keep-symbol=CheckParamBufferPrmHandler

@abdattar, I'm fine to merge this and leave the tool issue open to improve the tool behavior. Does that sound good to you?

Correct the GCC GenFw and ld flag to build PRM run time modules.
These changes are made for X64 GCC compiler, current present for AARCH64 only.
Adds addition _X64_OBJCOPY_STRIPFLAG for X64 to retain required symbol
during objcopy.

Signed-off-by: Abdul Lateef Attar <[email protected]>
@abdattar
Copy link
Contributor Author

@makubacki, sounds good.
Rebased and updated the commit message to make it ready for merge.

@makubacki makubacki added the push Auto push patch series in PR if all checks pass label Mar 27, 2025
@mergify mergify bot merged commit 9006a9b into tianocore:master Mar 27, 2025
126 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
push Auto push patch series in PR if all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants