-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PrmPkg: Correct the flags for GCC compiler #10875
Conversation
⚠ WARNING: Cannot add some reviewers: A user specified as a reviewer for this PR is not a collaborator of the repository. Please add them as a collaborator to the repository so they can be requested in the future. Non-collaborators requested: Attn Admins: Admin Instructions:
|
opened issue for the failure. |
PrmPkg/Samples/PrmSampleContextBufferModule/PrmSampleContextBufferModule.inf
Show resolved
Hide resolved
Please check and fix the CI failures. Otherwise the code change looks good! |
Looks like basetool issue and i opened the issue to address the same. |
PrmPkg/Samples/PrmSampleAcpiParameterBufferModule/PrmSampleAcpiParameterBufferModule.inf
Show resolved
Hide resolved
@abdattar, thank you for the change and addressing the PR comments. If someone doesn't pick up the BaseTool change needed by next week, I'll take a look. |
Fix the build failure by adding below build option to retain the symbols |
@abdattar, I'm fine to merge this and leave the tool issue open to improve the tool behavior. Does that sound good to you? |
Correct the GCC GenFw and ld flag to build PRM run time modules. These changes are made for X64 GCC compiler, current present for AARCH64 only. Adds addition _X64_OBJCOPY_STRIPFLAG for X64 to retain required symbol during objcopy. Signed-off-by: Abdul Lateef Attar <[email protected]>
@makubacki, sounds good. |
Description
Correct the GCC GenFw and ld flag to build PRM run time modules.
These changes are made for X64 GCC compiler, current present for AARCH64 only.
How This Was Tested
Build on Ubuntu environment
Integration Instructions
N/A