ArmPlatformPkg/PeilessSec: get rid of _SetSVCMode #10880
+0
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AArch64 has no SVC mode, this was clearly copied from the AArch32 version, so drop it. Signed-off-by: Leif Lindholm <[email protected]>
_SetSVCMode sits shortly after _ModuleEntryPoint, to switch into SVC mode and mask FIQ and IRQ exceptions (making it badly named to boot). But this should always be the state we start executing in, so most likely this is another remnant of a time when the edk2 image also contained Secure Monitor code, which has not been supported for some time now. Delete the whole stanza and see if anything breaks. Signed-off-by: Leif Lindholm <[email protected]>
github-actions
bot
added
the
impact:breaking-change
tianocore-assign-reviewers
bot
requested review from
ardbiesheuvel and
samimujawar
ardbiesheuvel
approved these changes
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First spotted the _SetSVCMode symbol in the ModuleEntryPoint.S during
review of an unrelated PR. This is clearly bogus since there is no SVC
mode in AArch64, and there is indeed no actual code associated with the
symbol.
Then looked at the AArch32 version, which does update the CPSR to
Set SVC mode
Mask FIQ and IRQ exceptions
but this is the expected mode for entering edk2 anyway, so my guess
is this change is irrelevant for any current users.
So delete it and see if anyone notices.
Breaking change?
How This Was Tested
Compile-tested only, we know it's a NOP in normal use on AArch32.