StandaloneMM fixes for x86 #5814
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EFI_FV_FILETYPE_MM_STANDALONE contains PE32 images, so add it to the list to make sure the files are also rebased. Cc: Bob Feng <[email protected]> Cc: Liming Gao <[email protected]> Cc: Rebecca Cran <[email protected]> Cc: Yuwei Chen <[email protected]> Signed-off-by: Patrick Rudolph <[email protected]>
PE32 in StandaloneMmPkg can be loaded into memory can be executed in place (XiP). That saves memory as they don't need to be relocated to memory when already residing in memory. Cc: Ard Biesheuvel <[email protected]> Cc: Jiaxin Wu <[email protected]> Cc: Ray Ni <[email protected]> Cc: Sami Mujawar <[email protected]> Signed-off-by: Patrick Rudolph <[email protected]>
Currently the StandaloneMm loader needs to find a free memory range in the secure world and provide it to StandaloneMM to use it as free pool for runtime memory allocations. The caller might not now how much memory space to allocate. In addition allocating a separate memory region in the trusted MM memory space increases the complexity on the MM loader side. Add a PCD that allows to use a fixed size memory buffer on the heap as free memory pool. Using this option will increase the binary size, but it removes the callers need to provide a memory range that can be used as runtime memory. Cc: Ard Biesheuvel <[email protected]> Cc: Jiaxin Wu <[email protected]> Cc: Ray Ni <[email protected]> Cc: Sami Mujawar <[email protected]> Signed-off-by: Patrick Rudolph <[email protected]>
Add missing EFIAPI qualifier. Cc: Ard Biesheuvel <[email protected]> Cc: Jiaxin Wu <[email protected]> Cc: Ray Ni <[email protected]> Cc: Sami Mujawar <[email protected]> Signed-off-by: Patrick Rudolph <[email protected]>
PatrickRudolph
force-pushed
the
UpstreamStandaloneMM
branch
from
6b98243
to
2e35918
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
StandaloneMM fixes for x86.
How This Was Tested
Build using edk2-platform.
Integration Instructions
N/A