Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SignedCapsulePkg: make Doxygen interpret ASCII art as verbatim text #6476

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

bexcran
Copy link
Contributor

@bexcran bexcran commented Nov 27, 2024

Description

By default, Doxygen tries to nicely format all text within doc blocks.
Unfortunately this mangles ASCII art: add @verbatim statements
to EdkiiSystemFmpCapsule.h to cause Doxygen to display the text as
provided.

  • Breaking change?
    • Breaking change - Does this PR cause a break in build or boot behavior?
    • Examples: Does it add a new library class or move a module to a different repo.
  • Impacts security?
    • Security - Does this PR have a direct security impact?
    • Examples: Crypto algorithm change or buffer overflow fix.
  • Includes tests?
    • Tests - Does this PR include any explicit test code?
    • Examples: Unit tests or integration tests.

How This Was Tested

Ran Doxygen after making the changes and verified the page at https://bsdio.com/edk2/docs/master/_edkii_system_fmp_capsule_8h.html is now displayed correctly.

Integration Instructions

Depends on #10714.

@bexcran bexcran force-pushed the fmp-capsule-ascii-doc branch 2 times, most recently from 9fc682b to d7ddbca Compare December 2, 2024 15:21
Copy link

This PR has been automatically marked as stale because it has not had activity in 60 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions.

@github-actions github-actions bot added the stale Due to lack of updates, this item is pending deletion. label Jan 31, 2025
@bexcran
Copy link
Contributor Author

bexcran commented Jan 31, 2025

This is still relevant.
@leiflindholm, @mdkinney or @ajfish Could one of you review this please?

@github-actions github-actions bot removed the stale Due to lack of updates, this item is pending deletion. label Feb 1, 2025
bexcran added a commit to bexcran/edk2 that referenced this pull request Feb 3, 2025
Per the discussion in tianocore#6476,
update Ecc code to allow the @verbatim Doxygen tag.

Signed-off-by: Rebecca Cran <[email protected]>
bexcran added a commit to bexcran/edk2 that referenced this pull request Feb 3, 2025
Per the discussion in tianocore#6476,
update Ecc code to allow the @verbatim Doxygen tag.

Signed-off-by: Rebecca Cran <[email protected]>
@bexcran bexcran force-pushed the fmp-capsule-ascii-doc branch 2 times, most recently from 899f42f to d463018 Compare February 3, 2025 12:29
@bexcran bexcran changed the title SignedCapsulePkg: make Doxygen interpret ASCII art as unparsed code SignedCapsulePkg: make Doxygen interpret ASCII art as verbatim text Feb 3, 2025
@bexcran bexcran self-assigned this Feb 3, 2025
bexcran added a commit to bexcran/edk2 that referenced this pull request Feb 3, 2025
Per the discussion in tianocore#6476,
update Ecc code to allow the @verbatim Doxygen tag.

Signed-off-by: Rebecca Cran <[email protected]>
@mdkinney mdkinney added this to the edk2-stable202502 milestone Feb 3, 2025
mergify bot pushed a commit that referenced this pull request Feb 4, 2025
Per the discussion in #6476,
update Ecc code to allow the @verbatim Doxygen tag.

Signed-off-by: Rebecca Cran <[email protected]>
By default, Doxygen tries to nicely format all text within doc blocks.
Unfortunately this mangles ASCII art: add @verbatim statements
to EdkiiSystemFmpCapsule.h to cause Doxygen to display the text as
provided.

Signed-off-by: Rebecca Cran <[email protected]>
@bexcran bexcran force-pushed the fmp-capsule-ascii-doc branch from d463018 to c956799 Compare February 4, 2025 00:12
@bexcran bexcran added the push Auto push patch series in PR if all checks pass label Feb 4, 2025
@mergify mergify bot merged commit fe5c2df into tianocore:master Feb 4, 2025
125 checks passed
@bexcran bexcran deleted the fmp-capsule-ascii-doc branch February 4, 2025 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
push Auto push patch series in PR if all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants