Skip to content

updated auth labels to make it clear about default region and url #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
0verwritten wants to merge 1 commit into
base: master
Choose a base branch
from
Open

updated auth labels to make it clear about default region and url #74

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions src/core/auth/auth-handler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,9 @@ export class AuthHandler {

const idcMethod = new IdcAuthMethod(this.config, this.repository, this.accountManager)

const configStartUrl = this.config.idc_start_url
const configRegion = this.config.idc_region

return [
{
label: 'AWS Builder ID / IAM Identity Center',
Expand All @@ -47,7 +50,9 @@ export class AuthHandler {
{
type: 'text' as const,
key: 'start_url',
message: 'IAM Identity Center Start URL (leave blank for AWS Builder ID)',
message: configStartUrl
? `IAM Identity Center Start URL (current: ${configStartUrl}, leave blank to keep)`
: 'IAM Identity Center Start URL (leave blank for AWS Builder ID)',
placeholder: 'https://your-company.awsapps.com/start',
validate: (value: string) => {
if (!value) return undefined
Expand All @@ -62,7 +67,10 @@ export class AuthHandler {
{
type: 'text' as const,
key: 'idc_region',
message: 'IAM Identity Center region (sso_region) (leave blank for us-east-1)',
message:
configRegion && configRegion !== 'us-east-1'
? `IAM Identity Center region (sso_region) (current: ${configRegion}, leave blank to keep)`
: 'IAM Identity Center region (sso_region) (leave blank for us-east-1)',
placeholder: 'us-east-1',
validate: (value: string) => {
if (!value) return undefined
Expand Down