Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seat 285 #233

Merged
merged 14 commits into from
Nov 27, 2023
Merged

Seat 285 #233

merged 14 commits into from
Nov 27, 2023

Conversation

tevo-nikita-ivashkov
Copy link
Contributor

@tevo-nikita-ivashkov tevo-nikita-ivashkov commented Nov 21, 2023

Jira: SEAT-285

Why / What

This PR:

  • updates dependencies
  • converts repo to monorepo
  • switches build tooling to tsup and changes package structure
  • adds ts definitions to package build
  • fixes tests for new version of react
  • extracts usage examples into separate packages
  • introduces CI pipelines with auto publish from main branch through changesets.

Testing

I tested this code by running unit tests.

Reviewer Checklist (To be edited and marked by approver)

After approving the PR, the reviewer should check the boxes below. See the Reviewer Checklist company standard for more info on these bullet points.

  • Do you understand the reasoning behind the need for the changes?
  • Given only new or existing tests*, do you feel confident that all changes work as intended and solve the problem at hand?
  • Are all success and failure paths accounted for in the tests? If not, are the omissions explained/justified?
  • If coverage ignores are present, is justification provided inline (or linked to) or is a link to a ticket to address in the future provided?
  • Are you willing to accept the same responsibility for this code as the author?

*If existing tests, requester should point out what applies

PR Code Coverage

  • Changeset: XX%
  • Overall: XX%

Measure with bin/test_cov or some other means. You can find html coverage levels in coverage/index.html or in stdout.

After a successful test run, you can also see calculated and merged coverage, per branch, on Grafana

- chore: Switched to pnpm
- deps: Updated build dependencies
- deps: Declared peer dependencies
- build: Switched from Webpack to tsup
- refactor: Changed package exports structure
- feat: Added ESM and CJS builds
- dev: Added bundle analyzer
- types: Added TypeScript definitions to build
- build: Configured monorepo setup
- deps: Updated linting dependencies
- dev: Added Husky for pre-commit hooks
- chore: Implemented changesets for versioning and changelogs
chore: package build configs clean up
tests: extracted mock-data into a separate package
@tevo-nikita-ivashkov tevo-nikita-ivashkov requested a review from a team November 21, 2023 20:03
@coneybeare
Copy link
Member

I changed the action to dynamically generate a one-time use token

@coneybeare
Copy link
Member

Working on adding npm token as well

@coneybeare
Copy link
Member

Ok, npm account recovered, updated, and token generated. Stored under TEVO_NPM_TOKEN

@@ -0,0 +1,80 @@
import "unfetch/polyfill";

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better to use single quotes instead of double ones throughout the project like we do it in the Shell project. Anyway it's a minor comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think better use same prettier configs in all projects

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tried to limit style changes compared to the previous version, but I agree with you guys on the consistency argument.
Will change the prettier config in a separate PR.

Copy link

@tevo-andrei-lukin tevo-andrei-lukin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its hard to properly review all of that, but surface level looks good, only minor complains about prettier settings.

@tevo-nikita-ivashkov tevo-nikita-ivashkov merged commit df611b3 into master Nov 27, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants