-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Seat 285 #233
Seat 285 #233
Conversation
- chore: Switched to pnpm - deps: Updated build dependencies - deps: Declared peer dependencies - build: Switched from Webpack to tsup - refactor: Changed package exports structure - feat: Added ESM and CJS builds - dev: Added bundle analyzer - types: Added TypeScript definitions to build
- build: Configured monorepo setup - deps: Updated linting dependencies - dev: Added Husky for pre-commit hooks - chore: Implemented changesets for versioning and changelogs
chore: package build configs clean up tests: extracted mock-data into a separate package
I changed the action to dynamically generate a one-time use token |
Working on adding npm token as well |
Ok, npm account recovered, updated, and token generated. Stored under |
@@ -0,0 +1,80 @@ | |||
import "unfetch/polyfill"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's better to use single quotes instead of double ones throughout the project like we do it in the Shell project. Anyway it's a minor comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think better use same prettier configs in all projects
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tried to limit style changes compared to the previous version, but I agree with you guys on the consistency argument.
Will change the prettier config in a separate PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its hard to properly review all of that, but surface level looks good, only minor complains about prettier settings.
Jira: SEAT-285
Why / What
This PR:
Testing
I tested this code by running unit tests.
Reviewer Checklist (To be edited and marked by approver)
After approving the PR, the reviewer should check the boxes below. See the Reviewer Checklist company standard for more info on these bullet points.
*If existing tests, requester should point out what applies
PR Code Coverage
Measure with
bin/test_cov
or some other means. You can find html coverage levels incoverage/index.html
or instdout
.After a successful test run, you can also see calculated and merged coverage, per branch, on Grafana