Skip to content

SEAT-294: hiding empty controls containers#250

Merged
tevo-nikita-ivashkov merged 1 commit intomasterfrom
SEAT-294
Jan 12, 2024
Merged

SEAT-294: hiding empty controls containers#250
tevo-nikita-ivashkov merged 1 commit intomasterfrom
SEAT-294

Conversation

@tevo-nikita-ivashkov
Copy link
Copy Markdown
Contributor

Jira: JIRA-TOKEN

Why / What

This PR fixes visual bug with empty control containers showing as borders.

Testing

I tested this code manually

Reviewer Checklist (To be edited and marked by approver)

After approving the PR, the reviewer should check the boxes below. See the Reviewer Checklist company standard for more info on these bullet points.

  • Do you understand the reasoning behind the need for the changes?
  • Given only new or existing tests*, do you feel confident that all changes work as intended and solve the problem at hand?
  • Are all success and failure paths accounted for in the tests? If not, are the omissions explained/justified?
  • If coverage ignores are present, is justification provided inline (or linked to) or is a link to a ticket to address in the future provided?
  • Are you willing to accept the same responsibility for this code as the author?

*If existing tests, requester should point out what applies

PR Code Coverage

  • Changeset: XX%
  • Overall: XX%

Measure with bin/test_cov or some other means. You can find html coverage levels in coverage/index.html or in stdout.

After a successful test run, you can also see calculated and merged coverage, per branch, on Grafana

@tevo-nikita-ivashkov tevo-nikita-ivashkov requested a review from a team January 11, 2024 19:31
Copy link
Copy Markdown
Contributor

@bsl782 bsl782 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@tevo-nikita-ivashkov tevo-nikita-ivashkov merged commit 3343aa4 into master Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants