Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve type inference of execute result #72

Merged
merged 3 commits into from
Oct 31, 2024
Merged

improve type inference of execute result #72

merged 3 commits into from
Oct 31, 2024

Conversation

zoubingwu
Copy link
Contributor

@zoubingwu zoubingwu commented Oct 17, 2024 •
edited
Loading

Automatically infer whether to return FullResult or Rows[] based on the fullResult props.

without fullResult or fullResult is false:
image
image

fullResult is true:
image
image

@shiyuhang0 shiyuhang0 closed this Oct 23, 2024
@shiyuhang0 shiyuhang0 reopened this Oct 23, 2024
@shiyuhang0
Copy link
Collaborator

shiyuhang0 commented Oct 24, 2024 •
edited
Loading

IT passed in #74 with the same code change.

@shiyuhang0 shiyuhang0 merged commit 529da93 into tidbcloud:main Oct 31, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shiyuhang0 shiyuhang0 shiyuhang0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zoubingwu @shiyuhang0