feat: Implement a method to change the device id #5
+20
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doudou
reviewed
Dec 13, 2024
| @@ -96,6 +96,18 @@ int main(int argc, char** argv) | |||
| } | |||
| std::cout << wp_device.getConfig() << std::endl; | |||
| } | |||
| else if (cmd == "set_id") { | |||
There was a problem hiding this comment.
Also update the usage message at the top of the file please (add the dc-cube command as well)
wvmcastro
reviewed
Dec 19, 2024
| waitResult(*can_device, device, device.querySerialNumber()); | ||
| uint32_t serial_number = device.getSerialNumber(); | ||
| int device_new_id(std::stoi(argv[6])); | ||
| waitResult(*can_device, device, device.querySetId(device_new_id, serial_number)); |
There was a problem hiding this comment.
we verified in live that we should send the set id query to can id 0x600 (broadcast)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for
[sc-65148]
How I did it
Results, How I tested
Checklist