Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Placement of the eval_time argument #104

Merged
merged 7 commits into from
Feb 28, 2024
Merged

Placement of the eval_time argument #104

merged 7 commits into from
Feb 28, 2024

Conversation

hfrick
Copy link
Member

@hfrick hfrick commented Feb 27, 2024

Follow on to tidymodels/tune#857

@hfrick hfrick mentioned this pull request Feb 27, 2024
Merged
simonpcouch
simonpcouch approved these changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@simonpcouch simonpcouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Existing changes all look good. :)

I think show_best.tune_race() needs a change here, as well? That would also need a NEWS entry since the dots are placed such that passing n by position is broken.

@simonpcouch simonpcouch merged commit 7bbb18f into main Feb 28, 2024
8 checks passed
@simonpcouch simonpcouch deleted the eval_time-placement branch February 28, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonpcouch simonpcouch simonpcouch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hfrick @simonpcouch