Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move away from using map_dfr() #119

Merged

Conversation

SokolovAnatoliy
Copy link
Contributor

Updating superseded map_dfr to map %>% list_rbind. Fixes #115.

@simonpcouch simonpcouch self-assigned this Aug 15, 2024
Copy link
Contributor

@simonpcouch simonpcouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!🤩

Kinda funky that we namespace with purrr:: in some places and not in others, but I think you've done the right thing here in just matching the style in the given file.

Will wait on checks to pass before merging.

Copy link

@lionel- lionel- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Can you also change the required version of purrr to 1.0.0 please?

purrr,

@simonpcouch simonpcouch merged commit a016fba into tidymodels:main Aug 15, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

transition from deprecated map_dfr() in autoplot() internals
3 participants