Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to hardhat's version of contr_one_hot() #1239

Merged
merged 2 commits into from
Jan 29, 2025
Merged

Conversation

hfrick
Copy link
Member

@hfrick hfrick commented Jan 28, 2025

closes #1215, as a pair with tidymodels/hardhat#278

@hfrick
Copy link
Member Author

hfrick commented Jan 28, 2025

That failed check is one on the parsnip overhead but since that test passes on all other platforms, I think it's not related to this change.

@hfrick hfrick requested a review from topepo January 28, 2025 18:03
Copy link
Member

@topepo topepo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I ran revdeps and there was a good test case in the LorenzRegression package (using parsnip::contr_one_hot())

@topepo
Copy link
Member

topepo commented Jan 29, 2025

Although I do see an additional warning for

Found the following significant warnings:
Warning: replacing previous import ‘hardhat::contr_one_hot’ by
‘parsnip::contr_one_hot’ when loading ‘viralmodels’

I'll add an issues to their repo.

@topepo topepo merged commit 8adb5cc into main Jan 29, 2025
10 checks passed
@topepo topepo deleted the consolidate-contr_one_hot branch January 29, 2025 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

contr_one_hot() is also in hardhat but not exported
2 participants