-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand grouping variables for bootstrap intervals #465
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally on board with this, go ahead with adding more unit tests 👍
This is ready for final review. I've set up the |
* add maybe_choose_eval_time * re-write survival bits * update/fix tests * nocov * added additional test * version bump * changes based on reviewer feedback * updates to work with tidymodels/rsample#465 * update snapshots --------- Co-authored-by: ‘topepo’ <‘[email protected]’>
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
For some tune internals, it would be helpful to be able to make intervals for an extended set of column columns (s opposed to just
terms
). See tidymodels/tune#818.These changes are a proposal to expand things to include columns starting with a period. We can discuss it, and I can create more unit tests if we're good with this.
Here's an example:
library(tidymodels)
Created on 2024-01-19 with reprex v2.0.2