Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't export .get_split_args() #495

Closed
wants to merge 1 commit into from
Closed

Conversation

hfrick
Copy link
Member

@hfrick hfrick commented May 24, 2024

until we need to and

Since we were able to make do in tidymodels/tune#894 with that just function, no pressure from me to export or otherwise mobilize further here.

#483 (comment)

@simonpcouch
Copy link
Contributor

I did just complicate this story in #489 (comment). Will defer to you here.🤔

@hfrick
Copy link
Member Author

hfrick commented May 24, 2024

Summary of discussion under #489 (comment)
We'll leave this PR open for now and see if we end up using this helper in tune after all. If not, we'll merge this.

@simonpcouch
Copy link
Contributor

tune now does indeed use this helper, so I will go ahead and close.🐬

@simonpcouch simonpcouch deleted the unexport-get_split_args branch May 31, 2024 17:56
Copy link

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Jun 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants