-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Parity between folders in R/ and in tests/testthat/
#6738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
teunbrand
wants to merge
69
commits into
tidyverse:main
Choose a base branch
from
teunbrand:test_symmetry
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+5,816
−5,260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is upkeep and has no related issue.
It brings ggplot2 into the convention that there are pairs of code and test files, making it easy to spot what some test file is testing and where to find tests associated with a code file. To do this, I often:
Renamed test files, to match the
R/file.Renamed some
R/files to better its intent, for example:aes-evaluation.Rwas about the delayed evaluation mechanism, not evaluation in general.performance.Rcontained utilities, so it seemed more clear to me to name thisutilities-performance.Rinstead.Merged files when testing was also tightly intertwined.
geom-col.Randgeom-bar.Rare essentially the same thingR/geom-abline-hline-vline.Rfile.Split up test files when implementation was spread out over multiple files.
test-theme.Rcontained all tests for themes, whereas there are 5theme-{subject}.Rfiles.facet_grid()andfacet_wrap().There are a few notable exceptions to pairing:
Several
R/files, lack a corresponding test file. Typically this occurs when functionality is already implicitly covered in another test, likegeom_density()being covered by tests forstat_density().There is a 'meta' test in
tests/testthat/test-prohibited-functions.Rthat tests the repository as a whole.Moreover there may be a few surprises: