Revert allowing data frames in list_transpose()

tidyverse · Aug 21, 2024 · 83043e2 · 83043e2
1 parent 213c12e
commit 83043e2
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 6 deletions.
diff --git a/R/list-transpose.R b/R/list-transpose.R
@@ -69,8 +69,7 @@ list_transpose <- function(x,
                            simplify = NA,
                            ptype = NULL,
                            default = NULL) {
-
-  check_list(x)
+  obj_check_list(x)
   check_dots_empty()
 
   if (length(x) == 0) {

diff --git a/tests/testthat/_snaps/list-transpose.md b/tests/testthat/_snaps/list-transpose.md
@@ -1,3 +1,11 @@
+# can't transpose data frames
+
+    Code
+      list_transpose(df)
+    Condition
+      Error in `list_transpose()`:
+      ! `x` must be a list, not a <data.frame> object.
+
 # integer template requires exact length of list() simplify etc
 
     Code
@@ -57,7 +65,7 @@
       list_transpose(10)
     Condition
       Error in `list_transpose()`:
-      ! `x` must be a list, not a number.
+      ! `x` must be a list, not the number 10.
     Code
       list_transpose(list(1), template = mean)
     Condition

diff --git a/tests/testthat/test-list-transpose.R b/tests/testthat/test-list-transpose.R
@@ -4,10 +4,13 @@ test_that("can transpose homogenous list", {
   expect_equal(out, list(a = c(x = 1, y = 3), b = c(x = 2, y = 4)))
 })
 
-test_that("can transpose data frames", {
+test_that("can't transpose data frames", {
   df <- data.frame(x = 1:2, y = 4:5)
-  out <- list_transpose(df)
-  expect_equal(out, list(c(x = 1, y = 4), c(x = 2, y = 5)))
+
+  # i.e. be consistent with other `list_*()` functions from purrr/vctrs
+  expect_snapshot(error = TRUE, {
+    list_transpose(df)
+  })
 })
 
 test_that("transposing empty list returns empty list", {