Improve split docs #530
Merged
Improve split docs #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jennybc
approved these changes
Oct 31, 2023
Comment on lines
+7
to
+10
| #' * `str_split_1()` takes a single string and splits it into pieces, | ||
| #' returning a single character vector. | ||
| #' * `str_split_i()` splits each string in a character vector into pieces and | ||
| #' extracts the `i`th value, returning a character vector. |
There was a problem hiding this comment.
This is not at all what I was asked to do / review but I'm still just noticing that these function names follow a common pattern. But then they do pretty different things. 🤔 I think this is the first time I've contemplated str_split_i().
There was a problem hiding this comment.
Yeah, they both return a character vector, but for rather different reasons. Probably too later to do much about it now.
Co-authored-by: Jennifer (Jenny) Bryan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.