Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

str_ilike() #544

Merged
merged 15 commits into from
Aug 20, 2024
Merged

str_ilike() #544

merged 15 commits into from
Aug 20, 2024

Conversation

edward-burn
Copy link
Contributor

@edward-burn edward-burn commented Apr 10, 2024 •
edited by hadley
Loading

  • add str_ilike function
  • deprecate ignore_case argument in str_like
  • add tests of case sensitivity for both
  • update NEWS.md
  • update _pkgdown.yml

Fixes #543

@edward-burn
str_ilike tidyverse#543
4e44ac0 
- add str_ilike function
- remove ignore_case argument from str_like
- add tests of case sensitivity for both
@edward-burn
update news
b0d8712
@edward-burn
Update _pkgdown.yml
ab4a491
@edward-burn
deprecate ignore_case instead of removing
d55540d
This was referenced Apr 10, 2024
Closed
Open
@hadley hadley changed the title str_ilike #543 str_ilike() Jul 15, 2024
hadley
hadley approved these changes Jul 15, 2024
View reviewed changes
Copy link
Member

@hadley hadley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! It's a long term process to fix a bug like this and I appreciate you sticking with it 😄

R/detect.R Outdated
stri_detect_regex(string, pattern, opts_regex = opts(pattern))
}

#' Detect a pattern in the same way as `SQL`'s `ILIKE` operator
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you could combine the docs for these two functions. It'd also be useful to add a note about the incorrect behaviour of older versions of str_like()

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hadley by this did you mean to use @inheritParams str_like? If so, I've added this here
1a366e3 But please let me know if I've misunderstood as I wasn't sure of what you meant

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant using @rdname; see the changes I just pushed.

R/detect.R Outdated Show resolved Hide resolved
tests/testthat/test-detect.R Outdated Show resolved Hide resolved
tests/testthat/test-detect.R Outdated Show resolved Hide resolved
@hadley hadley added the breaking change ☠️ API change likely to affect existing code label Jul 16, 2024
@hadley hadley merged commit 90f8ba7 into tidyverse:main Aug 20, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hadley hadley hadley approved these changes

Assignees
No one assigned
Labels
breaking change ☠️ API change likely to affect existing code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SQL's LIKE is actually case sensitive
2 participants
@edward-burn @hadley