-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tier4_system_msgs)!: remove old diagnostic graph message #145
base: tier4/universe
Are you sure you want to change the base?
Conversation
Signed-off-by: Takagi, Isamu <[email protected]>
autowarefoundation/autoware.universe#8722 is merged. This PR is ready. |
Note: The messages are already replaced by the new message merged in this PR #113 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but we should update autoware.repos to point to a version tag before merging. https://github.com/autowarefoundation/autoware/blob/c9c32480ecff40ce15c0bf7d51a77d67eb981e5e/autoware.repos#L53
@isamu-takagi Sorry, I had to revert this PR autowarefoundation/autoware#5749 once. We have to update the tag with v0.41.0 and create the version fix PR again. |
@mitsudome-r Can I merge this PR now? |
Related Links
autowarefoundation/autoware.universe#8722
Description
Remove old diagnostic graph messages that are no longer in use.
Remarks
None
Pre-Review Checklist for the PR Author
PR Author should check the checkboxes below when creating the PR.
Checklist for the PR Reviewer
Reviewers should check the checkboxes below before approval.
Post-Review Checklist for the PR Author
PR Author should check the checkboxes below before merging.
CI Checks