Skip to content

feat(tier4_system_msgs)!: remove old diagnostic graph message#145

Merged
mitsudome-r merged 2 commits intotier4/universefrom
feat/remove-old-diagnostic-graph
Jun 18, 2025
Merged

feat(tier4_system_msgs)!: remove old diagnostic graph message#145
mitsudome-r merged 2 commits intotier4/universefrom
feat/remove-old-diagnostic-graph

Conversation

@isamu-takagi
Copy link
Copy Markdown
Contributor

@isamu-takagi isamu-takagi commented Sep 3, 2024

Related Links

autowarefoundation/autoware_universe#8722

Description

Remove old diagnostic graph messages that are no longer in use.

Remarks

None

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Code is properly formatted
  • Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • Code is properly formatted
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets
  • Write release notes

CI Checks

  • Build and test for PR: Required to pass before the merge.
  • Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
@isamu-takagi
Copy link
Copy Markdown
Contributor Author

autowarefoundation/autoware_universe#8722 is merged. This PR is ready.

@mitsudome-r
Copy link
Copy Markdown
Collaborator

Note: The messages are already replaced by the new message merged in this PR #113

Copy link
Copy Markdown
Collaborator

@mitsudome-r mitsudome-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but we should update autoware.repos to point to a version tag before merging. https://github.com/autowarefoundation/autoware/blob/c9c32480ecff40ce15c0bf7d51a77d67eb981e5e/autoware.repos#L53

@mitsudome-r
Copy link
Copy Markdown
Collaborator

@isamu-takagi Sorry, I had to revert this PR autowarefoundation/autoware#5749 once. We have to update the tag with v0.41.0 and create the version fix PR again.

@isamu-takagi
Copy link
Copy Markdown
Contributor Author

@mitsudome-r Can I merge this PR now?

@mitsudome-r
Copy link
Copy Markdown
Collaborator

It should be okay now.

@mitsudome-r mitsudome-r merged commit 83051f4 into tier4/universe Jun 18, 2025
@mitsudome-r mitsudome-r deleted the feat/remove-old-diagnostic-graph branch June 18, 2025 12:26
TetsuKawa pushed a commit that referenced this pull request Jun 20, 2025
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants