feat(tier4_system_msgs)!: remove old diagnostic graph message#145
Merged
mitsudome-r merged 2 commits intotier4/universefrom Jun 18, 2025
Merged
feat(tier4_system_msgs)!: remove old diagnostic graph message#145mitsudome-r merged 2 commits intotier4/universefrom
mitsudome-r merged 2 commits intotier4/universefrom
Conversation
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Contributor
Author
|
autowarefoundation/autoware_universe#8722 is merged. This PR is ready. |
Collaborator
|
Note: The messages are already replaced by the new message merged in this PR #113 |
mitsudome-r
approved these changes
Jan 6, 2025
Collaborator
There was a problem hiding this comment.
LGTM, but we should update autoware.repos to point to a version tag before merging. https://github.com/autowarefoundation/autoware/blob/c9c32480ecff40ce15c0bf7d51a77d67eb981e5e/autoware.repos#L53
yukkysaito
approved these changes
Jan 6, 2025
Collaborator
|
@isamu-takagi Sorry, I had to revert this PR autowarefoundation/autoware#5749 once. We have to update the tag with v0.41.0 and create the version fix PR again. |
Contributor
Author
|
@mitsudome-r Can I merge this PR now? |
Collaborator
|
It should be okay now. |
TetsuKawa
pushed a commit
that referenced
this pull request
Jun 20, 2025
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Links
autowarefoundation/autoware_universe#8722
Description
Remove old diagnostic graph messages that are no longer in use.
Remarks
None
Pre-Review Checklist for the PR Author
PR Author should check the checkboxes below when creating the PR.
Checklist for the PR Reviewer
Reviewers should check the checkboxes below before approval.
Post-Review Checklist for the PR Author
PR Author should check the checkboxes below before merging.
CI Checks