Fix the irc bot #169
Merged
Fix the irc bot #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #169 +/- ##
=======================================
Coverage 80.81% 80.81%
=======================================
Files 42 42
Lines 7718 7718
=======================================
Hits 6237 6237
Misses 1481 1481 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been broken for many years. I didn't have much motivation to fix it because I wasn't actively using irc anymore.
Most of the libraries in the time in between have changed. I have to rewrite the bot from scratch.
Unfortunately, the async ecosystem in rust is split down the middle with tokio vs async-std.
ircuses tokio,rink-sandboxuses async-std, so they aren't compatible. I don't have the motivation to fix this yet, so for now the IRC bot has no sandboxing support.