Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display impls use token formatting #183

Merged
merged 4 commits into from
Jun 2, 2024
Merged

Conversation

tiffany352
Copy link
Owner

Deduplicates a bunch of code by having Display impls use the TokenFmt implementations. There were some bugs with the TokenFmt formatting that I had to fix, and some slight differences in their output that required adjusting tests. This also fixes a longstanding bug where there were 2 spaces in the output, like 42 (dimensionless).

I also got rid of that two-step pattern parsing stuff, it's simpler to iterate the chars of the pattern string instead.

Copy link

codecov bot commented Jun 2, 2024

Codecov Report

Attention: Patch coverage is 69.35484% with 19 lines in your changes are missing coverage. Please review.

Project coverage is 81.97%. Comparing base (09c5163) to head (c90650a).

Files Patch % Lines
core/src/output/reply.rs 15.38% 11 Missing ⚠️
core/src/output/fmt.rs 69.56% 7 Missing ⚠️
core/src/output/number_parts.rs 96.15% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #183      +/-   ##
==========================================
+ Coverage   81.83%   81.97%   +0.13%     
==========================================
  Files          42       42              
  Lines        7885     7632     -253     
==========================================
- Hits         6453     6256     -197     
+ Misses       1432     1376      -56     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tiffany352 tiffany352 marked this pull request as ready for review June 2, 2024 20:54
@tiffany352 tiffany352 merged commit 5859e92 into master Jun 2, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant