GH#1906: Update storage provisioners #1908
Conversation
✅ Deploy Preview for calico-docs-preview-next ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview succeeded!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
ctauchen
changed the title
| @@ -124,7 +124,7 @@ apiVersion: storage.k8s.io/v1 | |||
| kind: StorageClass | |||
| metadata: | |||
| name: tigera-elasticsearch | |||
| provisioner: kubernetes.io/azure-disk | |||
There was a problem hiding this comment.
@ctauchen I think other kubernetes.io-prefixed provisioners are deprecated too, not just kubernetes.io/azure-disk? there are more such occurences, such as kubernetes.io/aws-ebs and kubernetes.io/gce-pd
There was a problem hiding this comment.
Thanks, I've updated aws-ebs and gce-pd. I can't find anything else, though I am concerned that these external provisioners may require additional steps. Do they need to be separately installed? @moredatapls
There was a problem hiding this comment.
@ctauchen I am not sure about AWS and GCP but on AKS the providers do have to be activated while provisioning a cluster, see e.g. here: https://learn.microsoft.com/en-us/azure/aks/csi-storage-drivers#enable-csi-storage-drivers-on-an-existing-cluster
ctauchen
changed the title
| @@ -98,7 +98,7 @@ apiVersion: storage.k8s.io/v1 | |||
| kind: StorageClass | |||
| metadata: | |||
| name: tigera-elasticsearch | |||
| provisioner: kubernetes.io/aws-ebs | |||
| provisioner: provisioner: ebs.csi.aws.com | |||
There was a problem hiding this comment.
| provisioner: provisioner: ebs.csi.aws.com | |
| provisioner: ebs.csi.aws.com |
There was a problem hiding this comment.
Thanks, all fixed now.
The in-tree provisioners were migrated to external providers. They are now all deprecated or removed. This commit replaces the old in-tree values with their external counterparts. Resolves GH#1906
| @@ -124,7 +124,7 @@ apiVersion: storage.k8s.io/v1 | |||
| kind: StorageClass | |||
| metadata: | |||
| name: tigera-elasticsearch | |||
| provisioner: kubernetes.io/azure-disk | |||
| provisioner: disk.cni.azure.com | |||
| parameters: | |||
There was a problem hiding this comment.
We performed this migration last week and it turns out that the new provisioners also have a different parameter syntax. The available parameters for disk.cni.azure.com are listed here
The Azure parameters block should look as follows, I believe:
parameters:
cachingMode: ReadOnly
skuName: StandardSSD_LRSI am not sure about GCP and AWS, though
There was a problem hiding this comment.
see my other comments regarding GKE and EBS
| @@ -149,7 +149,7 @@ apiVersion: storage.k8s.io/v1 | |||
| kind: StorageClass | |||
| metadata: | |||
| name: tigera-elasticsearch | |||
| provisioner: kubernetes.io/gce-pd | |||
| provisioner: pd.csi.storage.gke.io | |||
There was a problem hiding this comment.
the GKE parameters look correct, see here
| @@ -98,7 +98,7 @@ apiVersion: storage.k8s.io/v1 | |||
| kind: StorageClass | |||
| metadata: | |||
| name: tigera-elasticsearch | |||
| provisioner: kubernetes.io/aws-ebs | |||
| provisioner: ebs.csi.aws.com | |||
There was a problem hiding this comment.
the EBS parameters are listed here
They would have to be changed as follows, I believe:
parameters:
type: gp2
"csi.storage.k8s.io/fstype": ext4
The in-tree provisioners were migrated to external providers. They are
now all deprecated or removed.
This commit replaces the old in-tree values with their external
counterparts.
Resolves #1906
Product Version(s):
Issue:
Link to docs preview:
SME review:
DOCS review:
Additional information:
Merge checklist: