Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH#1906: Update storage provisioners #1908

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

GH#1906: Update storage provisioners #1908

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions calico-enterprise/operations/logstorage/create-storage.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ apiVersion: storage.k8s.io/v1
kind: StorageClass
metadata:
name: tigera-elasticsearch
provisioner: kubernetes.io/aws-ebs
provisioner: ebs.csi.aws.com
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the EBS parameters are listed here

They would have to be changed as follows, I believe:

parameters:
  type: gp2
  "csi.storage.k8s.io/fstype": ext4

parameters:
type: gp2
fsType: ext4
Expand All @@ -124,7 +124,7 @@ apiVersion: storage.k8s.io/v1
kind: StorageClass
metadata:
name: tigera-elasticsearch
provisioner: kubernetes.io/azure-disk
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ctauchen I think other kubernetes.io-prefixed provisioners are deprecated too, not just kubernetes.io/azure-disk? there are more such occurences, such as kubernetes.io/aws-ebs and kubernetes.io/gce-pd

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see e.g. this document from AWS

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I've updated aws-ebs and gce-pd. I can't find anything else, though I am concerned that these external provisioners may require additional steps. Do they need to be separately installed? @moredatapls

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ctauchen I am not sure about AWS and GCP but on AKS the providers do have to be activated while provisioning a cluster, see e.g. here: https://learn.microsoft.com/en-us/azure/aks/csi-storage-drivers#enable-csi-storage-drivers-on-an-existing-cluster

provisioner: disk.cni.azure.com
parameters:
Copy link

@moredatapls moredatapls Feb 28, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We performed this migration last week and it turns out that the new provisioners also have a different parameter syntax. The available parameters for disk.cni.azure.com are listed here

The Azure parameters block should look as follows, I believe:

parameters:
  cachingMode: ReadOnly
  skuName: StandardSSD_LRS

I am not sure about GCP and AWS, though

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see my other comments regarding GKE and EBS

cachingmode: ReadOnly
kind: Managed
Expand All @@ -149,7 +149,7 @@ apiVersion: storage.k8s.io/v1
kind: StorageClass
metadata:
name: tigera-elasticsearch
provisioner: kubernetes.io/gce-pd
provisioner: pd.csi.storage.gke.io
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the GKE parameters look correct, see here

parameters:
type: pd-ssd
replication-type: none
Expand Down
6 changes: 3 additions & 3 deletions ...terprise_versioned_docs/version-3.18-2/operations/logstorage/create-storage.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ apiVersion: storage.k8s.io/v1
kind: StorageClass
metadata:
name: tigera-elasticsearch
provisioner: kubernetes.io/aws-ebs
provisioner: ebs.csi.aws.com
parameters:
type: gp2
fsType: ext4
Expand All @@ -124,7 +124,7 @@ apiVersion: storage.k8s.io/v1
kind: StorageClass
metadata:
name: tigera-elasticsearch
provisioner: kubernetes.io/azure-disk
provisioner: disk.cni.azure.com
parameters:
cachingmode: ReadOnly
kind: Managed
Expand All @@ -149,7 +149,7 @@ apiVersion: storage.k8s.io/v1
kind: StorageClass
metadata:
name: tigera-elasticsearch
provisioner: kubernetes.io/gce-pd
provisioner: pd.csi.storage.gke.io
parameters:
type: pd-ssd
replication-type: none
Expand Down
6 changes: 3 additions & 3 deletions ...terprise_versioned_docs/version-3.19-2/operations/logstorage/create-storage.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ apiVersion: storage.k8s.io/v1
kind: StorageClass
metadata:
name: tigera-elasticsearch
provisioner: kubernetes.io/aws-ebs
provisioner: ebs.csi.aws.com
parameters:
type: gp2
fsType: ext4
Expand All @@ -124,7 +124,7 @@ apiVersion: storage.k8s.io/v1
kind: StorageClass
metadata:
name: tigera-elasticsearch
provisioner: kubernetes.io/azure-disk
provisioner: disk.cni.azure.com
parameters:
cachingmode: ReadOnly
kind: Managed
Expand All @@ -149,7 +149,7 @@ apiVersion: storage.k8s.io/v1
kind: StorageClass
metadata:
name: tigera-elasticsearch
provisioner: kubernetes.io/gce-pd
provisioner: pd.csi.storage.gke.io
parameters:
type: pd-ssd
replication-type: none
Expand Down
6 changes: 3 additions & 3 deletions ...terprise_versioned_docs/version-3.20-1/operations/logstorage/create-storage.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ apiVersion: storage.k8s.io/v1
kind: StorageClass
metadata:
name: tigera-elasticsearch
provisioner: kubernetes.io/aws-ebs
provisioner: ebs.csi.aws.com
parameters:
type: gp2
fsType: ext4
Expand All @@ -124,7 +124,7 @@ apiVersion: storage.k8s.io/v1
kind: StorageClass
metadata:
name: tigera-elasticsearch
provisioner: kubernetes.io/azure-disk
provisioner: disk.cni.azure.com
parameters:
cachingmode: ReadOnly
kind: Managed
Expand All @@ -149,7 +149,7 @@ apiVersion: storage.k8s.io/v1
kind: StorageClass
metadata:
name: tigera-elasticsearch
provisioner: kubernetes.io/gce-pd
provisioner: pd.csi.storage.gke.io
parameters:
type: pd-ssd
replication-type: none
Expand Down
6 changes: 3 additions & 3 deletions ...terprise_versioned_docs/version-3.20-2/operations/logstorage/create-storage.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ apiVersion: storage.k8s.io/v1
kind: StorageClass
metadata:
name: tigera-elasticsearch
provisioner: kubernetes.io/aws-ebs
provisioner: ebs.csi.aws.com
parameters:
type: gp2
fsType: ext4
Expand All @@ -124,7 +124,7 @@ apiVersion: storage.k8s.io/v1
kind: StorageClass
metadata:
name: tigera-elasticsearch
provisioner: kubernetes.io/azure-disk
provisioner: disk.cni.azure.com
parameters:
cachingmode: ReadOnly
kind: Managed
Expand All @@ -149,7 +149,7 @@ apiVersion: storage.k8s.io/v1
kind: StorageClass
metadata:
name: tigera-elasticsearch
provisioner: kubernetes.io/gce-pd
provisioner: pd.csi.storage.gke.io
parameters:
type: pd-ssd
replication-type: none
Expand Down
6 changes: 3 additions & 3 deletions ...terprise_versioned_docs/version-3.21-1/operations/logstorage/create-storage.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ apiVersion: storage.k8s.io/v1
kind: StorageClass
metadata:
name: tigera-elasticsearch
provisioner: kubernetes.io/aws-ebs
provisioner: ebs.csi.aws.com
parameters:
type: gp2
fsType: ext4
Expand All @@ -124,7 +124,7 @@ apiVersion: storage.k8s.io/v1
kind: StorageClass
metadata:
name: tigera-elasticsearch
provisioner: kubernetes.io/azure-disk
provisioner: disk.cni.azure.com
parameters:
cachingmode: ReadOnly
kind: Managed
Expand All @@ -149,7 +149,7 @@ apiVersion: storage.k8s.io/v1
kind: StorageClass
metadata:
name: tigera-elasticsearch
provisioner: kubernetes.io/gce-pd
provisioner: pd.csi.storage.gke.io
parameters:
type: pd-ssd
replication-type: none
Expand Down