Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update host endpoint controller configuration #1933

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

MichalFupso
Copy link
Contributor

Update host endpoint configuration docs to include auto host endpoint updates
Product Version(s):

Calico, Calico Enterprise, and Calico Cloud
Issue:

Link to docs preview:

SME review:

  • An SME has approved this change.

DOCS review:

  • A member of the docs team has approved this change.

Additional information:

Merge checklist:

  • Deploy preview inspected wherever changes were made
  • Build completed successfully
  • Test have passed

@MichalFupso MichalFupso requested a review from a team as a code owner March 3, 2025 17:07
Copy link

netlify bot commented Mar 3, 2025

Deploy Preview for calico-docs-preview-next ready!

Name Link
🔨 Latest commit c7b7e84
🔍 Latest deploy log https://app.netlify.com/sites/calico-docs-preview-next/deploys/67c8d021ecf7d400085e7a02
😎 Deploy Preview https://deploy-preview-1933--calico-docs-preview-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 3, 2025

Deploy Preview succeeded!

Built without sensitive environment variables

Name Link
🔨 Latest commit c7b7e84
🔍 Latest deploy log https://app.netlify.com/sites/tigera/deploys/67c8d021b3d0b60008cff8f2
😎 Deploy Preview https://deploy-preview-1933--tigera.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 28 (🟢 up 5 from production)
Accessibility: 90 (no change from production)
Best Practices: 83 (no change from production)
SEO: 92 (🟢 up 7 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@ctauchen ctauchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments for you, @MichalFupso. Thanks for the PR!

@@ -4,6 +4,8 @@ description: API for KubeControllersConfiguration resource.

# Kubernetes controllers configuration

import Selectors from '@site/calico/_includes/content/_selectors.mdx';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency, please move to between the front matter and H1.

@@ -28,6 +28,9 @@ $[prodname] creates a wildcard host endpoint for each node, with the host endpoi
$[prodname] will ensure these managed host endpoints maintain the same labels and IP addresses as its node by periodic syncs.
This means that policy targeting these automatic host endpoints will function correctly with the policy put in place to select those nodes, even if over time the node's IPs or labels change.

$[prodname] is also able to create and manage custom host endpoints for nodes, based on user specified templates.
This allows you to fine tune which interfaces should be included in the host endpoint and for which nodes these host endpoints should be created. The host endpoint templates can be enabled by updating [KubeControllersConfig](../../reference/resources/kubecontrollersconfig)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This allows you to fine tune which interfaces should be included in the host endpoint and for which nodes these host endpoints should be created. The host endpoint templates can be enabled by updating [KubeControllersConfig](../../reference/resources/kubecontrollersconfig)
This allows you to fine-tune which interfaces should be included in the host endpoint and for which nodes these host endpoints should be created.
The host endpoint templates can be enabled by updating [KubeControllersConfig](../../reference/resources/kubecontrollersconfig.mdx).

| hostEndpoint | Controls allocation of host endpoints | | [HostEndpoint](#hostendpoint) | |
| reconcilerPeriod | Period to perform reconciliation with the $[prodname] datastore | | [Duration string][parse-duration] | 5m |
| syncLabels | When enabled, Kubernetes node labels will be copied to $[prodname] node objects. | Enabled, Disabled | string | Enabled |
| hostEndpoint | Configure the host endpoint controller | | [HostEndpoint](#hostendpoint) | |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| hostEndpoint | Configure the host endpoint controller | | [HostEndpoint](#hostendpoint) | |
| hostEndpoint | Configures the host endpoint controller | | [HostEndpoint](#hostendpoint) | |

| ------------------------- | ---------------------------------------------------------------- | ----------------- | --------------------- | -------- |
| autoCreate | When enabled, automatically create a host endpoints | Enabled, Disabled | string | Disabled |
| createDefaultHostEndpoint | When enabled, default host endpoint will be created | Enabled, Disabled | string | Enabled |
| templates | Controlls creation of custom host endpoints | | [Template](#template) | |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| templates | Controlls creation of custom host endpoints | | [Template](#template) | |
| templates | Controls creation of custom host endpoints | | [Template](#template) | |

| Field | Description | Accepted Values | Schema | Default |
| ------------------------- | ----------------------------------------------------------------------------------- | ------------------- | ---------------------- | -------- |
| name | Unique name used as suffix for host endpoints created based on this template | Alphanumeric string | string | |
| nodeSelector | Selects the nodes for which this template should create host endpoint | | [Selector](#selectors) | all() |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| nodeSelector | Selects the nodes for which this template should create host endpoint | | [Selector](#selectors) | all() |
| nodeSelector | Selects the nodes for which this template should create host endpoints | | [Selector](#selectors) | all() |

Comment on lines 101 to 105
### Label
| Field | Description | Accepted Values | Schema | Default |
| ------------------------- | ---------------------------------------------------------------- | ------------------- | --------- | -------- |
| name | Name for the label | Alphanumeric string | string | |
| value | Label value | Alphanumeric string | string | |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section seems not to add much value. I had a look at other resources, and none had a similar section.

Do we really need this?

| autoCreate | When enabled, automatically create a host endpoint for each node | Enabled, Disabled | string | Disabled |
| Field | Description | Accepted Values | Schema | Default |
| ------------------------- | ---------------------------------------------------------------- | ----------------- | --------------------- | -------- |
| autoCreate | When enabled, automatically create a host endpoints | Enabled, Disabled | string | Disabled |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| autoCreate | When enabled, automatically create a host endpoints | Enabled, Disabled | string | Disabled |
| autoCreate | When enabled, automatically create host endpoints | Enabled, Disabled | string | Disabled |

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants