-
Notifications
You must be signed in to change notification settings - Fork 3
GML-2015 Add UI page for configurations done in server_config.json #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
prinskumar-tigergraph
wants to merge
22
commits into
main
Choose a base branch
from
ui_page_server_config
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
…df4llm integration
…df4llm integration
…d local temp file support
…rect temp_folder cleanup
| <TabsTrigger value="AmazonBDA" disabled={isIngesting}> | ||
| <CloudLightning className="h-4 w-4 mr-2" /> | ||
| Use Amazon BDA | ||
| <TabsTrigger value="s3"> |
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@prinskumar-tigergraph is it on the latest main branch?
| </Dialog> | ||
|
|
||
| {/* Server Configuration Dialog */} | ||
| <Dialog |
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@prinskumar-tigergraph as discussed, let's put the config dialogs in a separate admin page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Enhancement, Bug fix
Description
Add real-time server config UI endpoints
Implement temp-file ingestion review workflow
Switch PDF extraction to
pymupdf4llmImprove thread-safety and image handling
Diagram Walkthrough
File Walkthrough
5 files
Temp-folder saving, PDF via pymupdf4llm, image handlingUse temp session storage; load from saved JSONAdd temp ingestion and server config REST endpointsDescribe images from file path; remove legacy saverUI: temp review flow, S3 ingest, server config1 files
Add in-memory config update with file persistence1 files
Replace PyMuPDF with pymupdf4llm; enable pathtools1 files
Add license for pymupdf4llm dependency