Skip to content

Conversation

@ac-mmi
Copy link

@ac-mmi ac-mmi commented Jul 12, 2024

Fixes #11

Added a separate semi-circle-progress.js and the corresponding style file. To use this component, include the following tag in your HTML:

<semi-circle-progress value="[value]" max="[max-value]"></semi-circle-progress>

@ac-mmi
Copy link
Author

ac-mmi commented Jul 26, 2024

@tigrr have you checked it

@tigrr
Copy link
Owner

tigrr commented Oct 26, 2025

Hi, @ac-mmi ,
Thank you for opening a PR and sorry for late response.
While I agree with the concept of having a half-circle (or gauge) progress, I see its possible implementation differently. Rather than duplicating the existing component almost entirely, I would like to augment it with the new functionality. Maybe add an attribute / property isGauge. Or taking it even further allow configuration of any start-end angle: in case of a gauge, it would be 180 degrees instead of 360. This could be realized by adding an endAngle property alongside with the existing startAngle property. So <circle-progress start-angle="-90" end-angle="90"></circle-progress> would produce an upper half circle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants