Skip to content

Commit

Permalink
Changed to Entrypoint and allow args in helm chart
Browse files Browse the repository at this point in the history
  • Loading branch information
tbrink committed Dec 4, 2023
1 parent 1e9cab3 commit 528ae7f
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 11 deletions.
6 changes: 4 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@ COPY --from=builder /usr/local/lib/python3.12/site-packages /usr/local/lib/pytho

COPY enviroplus_exporter.py .

CMD python3 enviroplus_exporter.py --bind=0.0.0.0 --port=8000
#CMD python3 enviroplus_exporter.py --bind=0.0.0.0 --port=8000

# ENTRYPOINT [ "python3", "enviroplus_exporter.py", "--bind=0.0.0.0", "--port=8000" ]
CMD [ "--bind=0.0.0.0", "--port=8000" ]

ENTRYPOINT [ "python3", "enviroplus_exporter.py" ]
2 changes: 1 addition & 1 deletion charts/enviroplus-exporter/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 0.1.0
version: 0.1.2

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
Expand Down
17 changes: 9 additions & 8 deletions charts/enviroplus-exporter/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -36,18 +36,19 @@ spec:
{{- toYaml .Values.securityContext | nindent 12 }}
image: "{{ .Values.image.repository }}:{{ .Values.image.tag | default .Chart.AppVersion }}"
imagePullPolicy: {{ .Values.image.pullPolicy }}
args: ["--bind=0.0.0.0", "--port=8000"]
ports:
- name: http
containerPort: {{ .Values.service.port }}
protocol: TCP
livenessProbe:
httpGet:
path: /
port: http
readinessProbe:
httpGet:
path: /
port: http
# livenessProbe:
# httpGet:
# path: /
# port: http
# readinessProbe:
# httpGet:
# path: /
# port: http
resources:
{{- toYaml .Values.resources | nindent 12 }}
volumes:
Expand Down

0 comments on commit 528ae7f

Please sign in to comment.