txnkv: optimize batch-get by reducing overhead of backoffer (#1559)

Signed-off-by: zyguan <[email protected]>
tikv · Jan 16, 2025 · 57aa917 · 57aa917
1 parent d22ee91
commit 57aa917
Showing 1 changed file with 10 additions and 4 deletions.
diff --git a/txnkv/txnsnapshot/snapshot.go b/txnkv/txnsnapshot/snapshot.go
@@ -360,13 +360,19 @@ func (s *KVSnapshot) batchGetKeysByRegions(bo *retry.Backoffer, keys [][]byte, r
 	if len(batches) == 1 {
 		return s.batchGetSingleRegion(bo, batches[0], readTier, collectF)
 	}
-	ch := make(chan error)
-	for _, batch1 := range batches {
+	ch := make(chan error, len(batches))
+	bo, cancel := bo.Fork()
+	defer cancel()
+	for i, batch1 := range batches {
+		var backoffer *retry.Backoffer
+		if i == 0 {
+			backoffer = bo
+		} else {
+			backoffer = bo.Clone()
+		}
 		batch := batch1
 		go func() {
 			growStackForBatchGetWorker()
-			backoffer, cancel := bo.Fork()
-			defer cancel()
 			ch <- s.batchGetSingleRegion(backoffer, batch, readTier, collectF)
 		}()
 	}