-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ttl for raw client #370
base: master
Are you sure you want to change the base?
Conversation
Seems like the clippy and integration test is failing. Clippy makes sense:
But for the integration tests I'll look into that |
Signed-off-by: andylokandy <[email protected]>
72d1520
to
61f4425
Compare
batch_put() api would give the following error:
tikv server: v6.1.3 I also tested tikv v4.0. It does not throw this error. Example: use tikv_client::{KvPair, RawClient};
#[tokio::main]
async fn main() -> Result<(), ()> {
let client = RawClient::new(vec!["127.0.0.1:12379"], None).await.unwrap();
let kvpair1: KvPair = KvPair("PD".to_owned().into(), "Go".to_owned().into());
let kvpair2: KvPair = KvPair("TiKV".to_owned().into(), "Rust".to_owned().into());
let pairs: Vec<KvPair> = vec![kvpair1, kvpair2];
match client.batch_put(pairs).await {
Ok(_) => println!("pairs are inserted"),
Err(e) => println!("error: {}", e),
};
Ok(())
} Output:
|
Indeed, that was also my observation. I'm not sure what's going on and I don't have a lot of time to work on this. I'll try to get to the bottom of this in the next couple of days though. If anyone has any clues, please share ;) |
just a wild guess. It may have something to do with the pb files. Let me also cross check the go client code to see if there is any finding. |
@@ -262,18 +274,25 @@ impl<PdC: PdClient> Client<PdC> { | |||
/// # }); | |||
/// ``` | |||
pub async fn put(&self, key: impl Into<Key>, value: impl Into<Value>) -> Result<()> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why removed put_ttl
in #324?
Based on #324 with the following additions:
(KvPair, u64)
toKvPairWithTTL