Skip to content

Commit 5d32653

Browse files
authored
client/tso: add a TSO wait failed duration observer (#8763)
ref #8281 Add a TSO wait failed duration observer. Signed-off-by: JmPotato <[email protected]>
1 parent 60b960a commit 5d32653

File tree

2 files changed

+8
-5
lines changed

2 files changed

+8
-5
lines changed

Diff for: client/metrics.go

+4-2
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,7 @@ func initMetrics(constLabels prometheus.Labels) {
139139
}
140140

141141
var (
142-
cmdDurationWait prometheus.Observer
142+
cmdDurationTSOWait prometheus.Observer
143143
cmdDurationTSO prometheus.Observer
144144
cmdDurationTSOAsyncWait prometheus.Observer
145145
cmdDurationGetRegion prometheus.Observer
@@ -166,6 +166,7 @@ var (
166166
cmdDurationUpdateServiceSafePointV2 prometheus.Observer
167167

168168
cmdFailDurationGetRegion prometheus.Observer
169+
cmdFailDurationTSOWait prometheus.Observer
169170
cmdFailDurationTSO prometheus.Observer
170171
cmdFailDurationGetAllMembers prometheus.Observer
171172
cmdFailDurationGetPrevRegion prometheus.Observer
@@ -189,7 +190,7 @@ var (
189190

190191
func initCmdDurations() {
191192
// WithLabelValues is a heavy operation, define variable to avoid call it every time.
192-
cmdDurationWait = cmdDuration.WithLabelValues("wait")
193+
cmdDurationTSOWait = cmdDuration.WithLabelValues("wait")
193194
cmdDurationTSO = cmdDuration.WithLabelValues("tso")
194195
cmdDurationTSOAsyncWait = cmdDuration.WithLabelValues("tso_async_wait")
195196
cmdDurationGetRegion = cmdDuration.WithLabelValues("get_region")
@@ -216,6 +217,7 @@ func initCmdDurations() {
216217
cmdDurationUpdateServiceSafePointV2 = cmdDuration.WithLabelValues("update_service_safe_point_v2")
217218

218219
cmdFailDurationGetRegion = cmdFailedDuration.WithLabelValues("get_region")
220+
cmdFailDurationTSOWait = cmdFailedDuration.WithLabelValues("wait")
219221
cmdFailDurationTSO = cmdFailedDuration.WithLabelValues("tso")
220222
cmdFailDurationGetAllMembers = cmdFailedDuration.WithLabelValues("get_member_info")
221223
cmdFailDurationGetPrevRegion = cmdFailedDuration.WithLabelValues("get_prev_region")

Diff for: client/tso_request.go

+4-3
Original file line numberDiff line numberDiff line change
@@ -74,13 +74,14 @@ func (req *tsoRequest) waitCtx(ctx context.Context) (physical int64, logical int
7474
defer req.pool.Put(req)
7575
defer trace.StartRegion(req.requestCtx, "pdclient.tsoReqDone").End()
7676
err = errors.WithStack(err)
77+
now := time.Now()
7778
if err != nil {
78-
cmdFailDurationTSO.Observe(time.Since(req.start).Seconds())
79+
cmdFailDurationTSOWait.Observe(now.Sub(start).Seconds())
80+
cmdFailDurationTSO.Observe(now.Sub(req.start).Seconds())
7981
return 0, 0, err
8082
}
8183
physical, logical = req.physical, req.logical
82-
now := time.Now()
83-
cmdDurationWait.Observe(now.Sub(start).Seconds())
84+
cmdDurationTSOWait.Observe(now.Sub(start).Seconds())
8485
cmdDurationTSO.Observe(now.Sub(req.start).Seconds())
8586
return
8687
case <-ctx.Done():

0 commit comments

Comments
 (0)