api: fix cannot dump trace (#7255) (#7265)

ti-chi-bot · nolouch · ti-chi-bot[bot] · web-flow · commit a54621ae5be7 · 2023-10-26T07:08:04.000Z
close #7253 api: fix cannot dump trace with dashboard Signed-off-by: nolouch <nolouch@gmail.com> Co-authored-by: nolouch <nolouch@gmail.com> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
diff --git a/server/util.go b/server/util.go
@@ -17,6 +17,7 @@ package server
 import (
 	"context"
 	"net/http"
+	"net/http/pprof"
 	"path/filepath"
 	"strings"
 
@@ -121,8 +122,13 @@ func combineBuilderServerHTTPService(ctx context.Context, svr *Server, serviceBu
 			userHandlers[pathPrefix] = handler
 		}
 	}
+
 	apiService.UseHandler(router)
 	userHandlers[pdAPIPrefix] = apiService
+
+	// fix issue https://github.com/tikv/pd/issues/7253
+	// FIXME: remove me after upgrade
+	userHandlers["/debug/pprof/trace"] = http.HandlerFunc(pprof.Trace)
 	return userHandlers, nil
 }
 

Original file line number	Diff line number	Diff line change
`@@ -17,6 +17,7 @@ package server`
`17`	`17`	`import (`
`18`	`18`	`"context"`
`19`	`19`	`"net/http"`
	`20`	`+ "net/http/pprof"`
`20`	`21`	`"path/filepath"`
`21`	`22`	`"strings"`
`22`	`23`
`@@ -121,8 +122,13 @@ func combineBuilderServerHTTPService(ctx context.Context, svr *Server, serviceBu`
`121`	`122`	`userHandlers[pathPrefix] = handler`
`122`	`123`	`}`
`123`	`124`	`}`
	`125`	`+`
`124`	`126`	`apiService.UseHandler(router)`
`125`	`127`	`userHandlers[pdAPIPrefix] = apiService`
	`128`	`+`
	`129`	`+ // fix issue https://github.com/tikv/pd/issues/7253`
	`130`	`+ // FIXME: remove me after upgrade`
	`131`	`+ userHandlers["/debug/pprof/trace"] = http.HandlerFunc(pprof.Trace)`
`126`	`132`	`return userHandlers, nil`
`127`	`133`	`}`
`128`	`134`