Skip to content

*: remove the code of Local TSO from PD client#8803

Merged
ti-chi-bot[bot] merged 3 commits intotikv:masterfrom
JmPotato:remove_local_tso
Nov 13, 2024
Merged

*: remove the code of Local TSO from PD client#8803
ti-chi-bot[bot] merged 3 commits intotikv:masterfrom
JmPotato:remove_local_tso

Conversation

@JmPotato
Copy link
Copy Markdown
Member

@JmPotato JmPotato commented Nov 12, 2024

What problem does this PR solve?

Issue Number: ref #8802.

What is changed and how does it work?

Remove the code of Local TSO from PD client.

Check List

Tests

  • Unit test
  • Integration test

Release note

None.

@JmPotato JmPotato added component/client Client logic. component/tso Timestamp Oracle. labels Nov 12, 2024
@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot Bot commented Nov 12, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot Bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 12, 2024
@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 12, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 73.84615% with 34 lines in your changes missing coverage. Please review.

Project coverage is 75.25%. Comparing base (f941078) to head (8450c32).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #8803      +/-   ##
==========================================
- Coverage   75.81%   75.25%   -0.57%     
==========================================
  Files         459      459              
  Lines       72004    71843     -161     
==========================================
- Hits        54592    54062     -530     
- Misses      13946    14324     +378     
+ Partials     3466     3457       -9
Flag Coverage Δ
unittests 75.25% <73.84%> (-0.57%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@JmPotato JmPotato marked this pull request as ready for review November 13, 2024 01:49
@ti-chi-bot ti-chi-bot Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 13, 2024
rleungx
rleungx reviewed Nov 13, 2024
View reviewed changes
Comment thread client/client.go Outdated
@ti-chi-bot ti-chi-bot Bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Nov 13, 2024
@JmPotato
Remove the code of Local TSO from PD client
c8870a6 
Signed-off-by: JmPotato <ghzpotato@gmail.com>
@JmPotato
Remove the suffix bits
4951bef 
Signed-off-by: JmPotato <ghzpotato@gmail.com>
@ti-chi-bot ti-chi-bot Bot added the lgtm label Nov 13, 2024
@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot Bot commented Nov 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: okJiang, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 13, 2024
@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot Bot commented Nov 13, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-13 03:19:30.744661738 +0000 UTC m=+412732.935530730: ☑️ agreed by rleungx.
  • 2024-11-13 08:54:55.906316932 +0000 UTC m=+432858.097185928: ☑️ agreed by okJiang.

@okJiang
Copy link
Copy Markdown
Member

okJiang commented Nov 13, 2024

/retest

@JmPotato
Add a warn log about the mismatched cluster IDs
8450c32 
Signed-off-by: JmPotato <ghzpotato@gmail.com>
@JmPotato
Copy link
Copy Markdown
Member Author

JmPotato commented Nov 13, 2024

/retest

@ti-chi-bot ti-chi-bot Bot merged commit ac133d8 into tikv:master Nov 13, 2024
@JmPotato JmPotato deleted the remove_local_tso branch November 13, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rleungx rleungx rleungx approved these changes

@nolouch nolouch Awaiting requested review from nolouch

@lhy1024 lhy1024 Awaiting requested review from lhy1024

+1 more reviewer

@okJiang okJiang okJiang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved component/client Client logic. component/tso Timestamp Oracle. dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JmPotato @okJiang @rleungx