Divide src/progress.rs into mods #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fullstop000 <[email protected]>
Signed-off-by: Fullstop000 <[email protected]>
Signed-off-by: Fullstop000 <[email protected]>
|
Hi @Fullstop000 ! I think this is a step in the right direction. :) In the future we may want to split things up more, and there are certainly other parts of Raft that could have this treatment, but I appreciate you choosing to do this in a bite sized chunk. Please take a moment to fix the merge conflict if you could. |
…e125_divide_progress_into_mods Signed-off-by: Fullstop000 <[email protected]> # Conflicts: # src/progress/progress_set.rs
|
PTAL @BusyJay |
BusyJay
previously approved these changes
Feb 25, 2019
siddontang
reviewed
Feb 25, 2019
Signed-off-by: Fullstop000 <[email protected]>
Hoverbear
previously approved these changes
Feb 25, 2019
…e125_divide_progress_into_mods Signed-off-by: Fullstop000 <[email protected]> # Conflicts: # src/progress/progress_set.rs # src/raft.rs
…ds' into issue125_divide_progress_into_mods
Signed-off-by: Fullstop000 <[email protected]>
Hoverbear
approved these changes
Mar 1, 2019
|
@BusyJay Was your last review a green approved check? :) Can you give another? |
BusyJay
approved these changes
Mar 29, 2019
|
Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#125
The original
src/progress.rsis divided intosrc/progress/{mod.rs, infights.rs, progress_set.rs}