Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raft:Fix one log append reject bug about MsgUnreachable msg #475

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tier-cap
Copy link

@tier-cap tier-cap commented Apr 21, 2022

Problem Description:
close tikv/tikv#11371

  1. When follower reject the appendlog requests, it will send a MsgUnreachable msg to leader
  2. But the MsgUnreachable is a local type which means only be used in inner raftcore, cannot transfered by net, which leads to some logic check failed.

Solution:

  1. Let the MsgUnreachable be a response message, and when leader receives, call the raft core step directly.

@tier-cap tier-cap force-pushed the fix-log-append-reject-bug branch from 1f58409 to 3dc6ec5 Compare April 21, 2022 13:07
@BusyJay
Copy link
Member

BusyJay commented Apr 21, 2022

I don't think it's a good idea. Internal messages mean we are subject to change without breaking any compatibility. You should define a new message on the TiKV side.

@tier-cap
Copy link
Author

tier-cap commented Apr 21, 2022

I don't think it's a good idea. Internal messages mean we are subject to change without breaking any compatibility. You should define a new message on the TiKV side.

I have two fix, one is this pr, the other is add a new msg type. but the change is more tthan this.
And, this pr has changed this msg to not inner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tikv error in log: Raft raft: cannot step raft local message
2 participants