Update LICENSE file to contain boilerplate project owner#533
Merged
gengliqi merged 2 commits intotikv:masterfrom Dec 8, 2023
Merged
Update LICENSE file to contain boilerplate project owner#533gengliqi merged 2 commits intotikv:masterfrom
gengliqi merged 2 commits intotikv:masterfrom
Conversation
As far as I understand the guidelines and looking at other projects (for example, Apache Kafka)
the LICENSE file must contain boilerplate ("Copyright [yyyy] [name of copyright owner]") whereas
other project files specific ("Copyright 2019 TiKV Project Authors").
Signed-off-by: Dzmitry Huba <huba@google.com>
tisonkun
approved these changes
Dec 7, 2023
Contributor
tisonkun
left a comment
tisonkun
left a comment
There was a problem hiding this comment.
Yes. This is the case.
Thank you!
Signed-off-by: Dzmitry Huba <huba@google.com>
Contributor
Author
|
Thank you for prompt review. It looks like currently the CI is broken due to unused import. I've added fix for it as well to be able to merge this change. Can you please look at the change one more time, @tisonkun? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As far as I understand the guidelines and looking at other projects (for example, Apache Kafka) the LICENSE file must contain boilerplate ("Copyright [yyyy] [name of copyright owner]") whereas other project files specific ("Copyright 2019 TiKV Project Authors").
Signed-off-by: Dzmitry Huba huba@google.com